diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 633ffb0..03acdb7 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -28,7 +28,10 @@ jobs: - name: Where Am I run: pwd; ls -l - + + - name: Versions + run: g++ --version + - name: Configure CMake # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make. # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type @@ -37,6 +40,7 @@ jobs: - name: Build # Build your program with the given configuration run: cd src; cmake --build ${{github.workspace}}/src/build --config ${{env.BUILD_TYPE}} --target seer - + - name: Build Result run: cd src; ls -l build/ + diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index c0e4b8f..b515dfc 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -13,9 +13,6 @@ set(CMAKE_AUTOMOC ON) set(CMAKE_AUTOUIC ON) set(CMAKE_AUTORCC ON) -set(CMAKE_CXX_FLAGS_DEBUG_INIT "-Wall") # Remove if your compiler -set(CMAKE_CXX_FLAGS_RELEASE_INIT "-Wall") # doesn't support the -Wall flag. - find_package(Qt5Core REQUIRED) find_package(Qt5Gui REQUIRED) find_package(Qt5Widgets REQUIRED) @@ -173,6 +170,11 @@ if(NOT CMAKE_BUILD_TYPE MATCHES Debug) #Release, RelWithDebInfo and MinSizeRel message("System type is" ${SYSTEM_TYPE}) endif() +# for Linux, BSD, Solaris, Minix +if(UNIX AND NOT APPLE) + add_compile_options(-Wall -Wextra -Wunused-result -pedantic -Werror) +endif() + add_compile_definitions(QT_DEPRECATED_WARNINGS) add_executable(${PROJECT_NAME} ${SYSTEM_TYPE} ${SOURCE_FILES}) diff --git a/src/SeerArrayVisualizerWidget.cpp b/src/SeerArrayVisualizerWidget.cpp index d48461a..4049273 100644 --- a/src/SeerArrayVisualizerWidget.cpp +++ b/src/SeerArrayVisualizerWidget.cpp @@ -59,7 +59,7 @@ SeerArrayVisualizerWidget::SeerArrayVisualizerWidget (QWidget* parent) : QWidget QObject::connect(titleLineEdit, &QLineEdit::returnPressed, this, &SeerArrayVisualizerWidget::handleTitleLineEdit); QObject::connect(pointsCheckBox, &QCheckBox::clicked, this, &SeerArrayVisualizerWidget::handlePointsCheckBox); QObject::connect(labelsCheckBox, &QCheckBox::clicked, this, &SeerArrayVisualizerWidget::handleLabelsCheckBox); - QObject::connect(lineTypeButtonGroup, QOverload::of(&QButtonGroup::buttonClicked), this, &SeerArrayVisualizerWidget::handleLineTypeButtonGroup); + QObject::connect(lineTypeButtonGroup, QOverload::of(&QButtonGroup::idClicked), this, &SeerArrayVisualizerWidget::handleLineTypeButtonGroup); // Restore window settings. readSettings(); @@ -149,7 +149,7 @@ void SeerArrayVisualizerWidget::handleText (const QString& text) { if (id_text.toInt() == _variableId) { - QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', QString::SkipEmptyParts); + QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', Qt::SkipEmptyParts); setVariableAddress(words.first()); } @@ -375,6 +375,9 @@ void SeerArrayVisualizerWidget::resizeEvent (QResizeEvent* event) { void SeerArrayVisualizerWidget::handleSplitterMoved (int pos, int index) { + Q_UNUSED(pos); + Q_UNUSED(index); + writeSettings(); } diff --git a/src/SeerDebugDialog.cpp b/src/SeerDebugDialog.cpp index b24a528..43d6bbb 100644 --- a/src/SeerDebugDialog.cpp +++ b/src/SeerDebugDialog.cpp @@ -33,7 +33,7 @@ SeerDebugDialog::SeerDebugDialog (QWidget* parent) : QDialog(parent) { QObject::connect(loadBreakpointsFilenameToolButton, &QToolButton::clicked, this, &SeerDebugDialog::handleLoadBreakpointsFilenameToolButton); QObject::connect(loadCoreFilenameToolButton, &QToolButton::clicked, this, &SeerDebugDialog::handleLoadCoreFilenameToolButton); QObject::connect(attachProgramPidToolButton, &QToolButton::clicked, this, &SeerDebugDialog::handleProgramPidToolButton); - QObject::connect(_runModeButtonGroup, QOverload::of(&QButtonGroup::buttonClicked), this, &SeerDebugDialog::handleRunModeChanged); + QObject::connect(_runModeButtonGroup, QOverload::of(&QButtonGroup::idClicked), this, &SeerDebugDialog::handleRunModeChanged); // Set initial run mode. handleRunModeChanged(-1); diff --git a/src/SeerEditorWidget.cpp b/src/SeerEditorWidget.cpp index aecef40..9d7c4c4 100644 --- a/src/SeerEditorWidget.cpp +++ b/src/SeerEditorWidget.cpp @@ -230,7 +230,7 @@ void SeerEditorWidget::handleSearchTextLineEdit () { return; } - int nMatches = sourceArea()->findText(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags(0))); + int nMatches = sourceArea()->findText(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags())); matchesLabel->setText(QString("(%1)").arg(nMatches)); } @@ -243,7 +243,7 @@ void SeerEditorWidget::handleSearchDownToolButton () { return; } - sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags(0))); + sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags())); } void SeerEditorWidget::handleSearchUpToolButton () { @@ -254,7 +254,7 @@ void SeerEditorWidget::handleSearchUpToolButton () { return; } - sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags(0)) | QTextDocument::FindBackward); + sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags()) | QTextDocument::FindBackward); } void SeerEditorWidget::handleSearchCloseToolButton () { diff --git a/src/SeerGdbConfigPage.cpp b/src/SeerGdbConfigPage.cpp index d5d0afe..70716ea 100644 --- a/src/SeerGdbConfigPage.cpp +++ b/src/SeerGdbConfigPage.cpp @@ -11,7 +11,7 @@ SeerGdbConfigPage::SeerGdbConfigPage(QWidget* parent) : QWidget(parent) { // Connect things. QObject::connect(gdbProgramToolButton, &QToolButton::clicked, this, &SeerGdbConfigPage::handleGdbProgramToolButton); - QObject::connect(styleButtonGroup, QOverload::of(&QButtonGroup::buttonClicked), this, &SeerGdbConfigPage::handleDprintfButtonGroup); + QObject::connect(styleButtonGroup, QOverload::of(&QButtonGroup::idClicked), this, &SeerGdbConfigPage::handleDprintfButtonGroup); } SeerGdbConfigPage::~SeerGdbConfigPage() { diff --git a/src/SeerGdbWidget.cpp b/src/SeerGdbWidget.cpp index a15edce..73e0876 100644 --- a/src/SeerGdbWidget.cpp +++ b/src/SeerGdbWidget.cpp @@ -1454,7 +1454,7 @@ void SeerGdbWidget::handleGdbDataDeleteExpressions (QString expressionids) { }else{ - QStringList ids = expressionids.split(' ', QString::SkipEmptyParts); + QStringList ids = expressionids.split(' ', Qt::SkipEmptyParts); bool first = true; for (int i=0; isetProgram(gdbProgram()); // Build the gdb argument list. - QStringList args = gdbArguments().split(' ', QString::SkipEmptyParts); + QStringList args = gdbArguments().split(' ', Qt::SkipEmptyParts); // Give the gdb process the argument list. _gdbProcess->setArguments(args); diff --git a/src/SeerMemoryVisualizerWidget.cpp b/src/SeerMemoryVisualizerWidget.cpp index f80eaf0..7031a41 100644 --- a/src/SeerMemoryVisualizerWidget.cpp +++ b/src/SeerMemoryVisualizerWidget.cpp @@ -130,7 +130,7 @@ void SeerMemoryVisualizerWidget::handleText (const QString& text) { if (id_text.toInt() == _variableId) { - QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', QString::SkipEmptyParts); + QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', Qt::SkipEmptyParts); setVariableAddress(words.first()); } diff --git a/src/SeerRegisterValuesBrowserWidget.cpp b/src/SeerRegisterValuesBrowserWidget.cpp index e0d76f9..c280a49 100644 --- a/src/SeerRegisterValuesBrowserWidget.cpp +++ b/src/SeerRegisterValuesBrowserWidget.cpp @@ -155,6 +155,8 @@ void SeerRegisterValuesBrowserWidget::refresh () { void SeerRegisterValuesBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; item->setToolTip(0, item->text(1) + " : " + item->text(2)); diff --git a/src/SeerSourceBrowserWidget.cpp b/src/SeerSourceBrowserWidget.cpp index d85f7de..7d56b58 100644 --- a/src/SeerSourceBrowserWidget.cpp +++ b/src/SeerSourceBrowserWidget.cpp @@ -144,6 +144,8 @@ void SeerSourceBrowserWidget::handleItemDoubleClicked (QTreeWidgetItem* item, in void SeerSourceBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; if (item->text(1) == "") { // Look at the FullName. diff --git a/src/SeerStackArgumentsBrowserWidget.cpp b/src/SeerStackArgumentsBrowserWidget.cpp index f3d876c..fcaf40b 100644 --- a/src/SeerStackArgumentsBrowserWidget.cpp +++ b/src/SeerStackArgumentsBrowserWidget.cpp @@ -123,6 +123,8 @@ void SeerStackArgumentsBrowserWidget::refresh () { void SeerStackArgumentsBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; if (item->text(0) != "") { diff --git a/src/SeerStackFramesBrowserWidget.cpp b/src/SeerStackFramesBrowserWidget.cpp index 18ff81b..a2de86f 100644 --- a/src/SeerStackFramesBrowserWidget.cpp +++ b/src/SeerStackFramesBrowserWidget.cpp @@ -183,6 +183,8 @@ void SeerStackFramesBrowserWidget::handleItemDoubleClicked (QTreeWidgetItem* ite void SeerStackFramesBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; item->setToolTip(0, item->text(0) + " : " + item->text(1) + " : " + item->text(2) + " : " + item->text(3)); diff --git a/src/SeerStackLocalsBrowserWidget.cpp b/src/SeerStackLocalsBrowserWidget.cpp index 66a84e9..12ed74c 100644 --- a/src/SeerStackLocalsBrowserWidget.cpp +++ b/src/SeerStackLocalsBrowserWidget.cpp @@ -209,6 +209,8 @@ void SeerStackLocalsBrowserWidget::handleItemCollapsed (QTreeWidgetItem* item) { void SeerStackLocalsBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; item->setToolTip(0, item->text(0) + " : " + item->text(2)); diff --git a/src/SeerThreadFramesBrowserWidget.cpp b/src/SeerThreadFramesBrowserWidget.cpp index 72207e3..f9bda47 100644 --- a/src/SeerThreadFramesBrowserWidget.cpp +++ b/src/SeerThreadFramesBrowserWidget.cpp @@ -212,6 +212,8 @@ void SeerThreadFramesBrowserWidget::handleItemDoubleClicked (QTreeWidgetItem* it void SeerThreadFramesBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; item->setToolTip(0, item->text(0) + " : " + item->text(1) + " : " + item->text(3) + " : " + item->text(4) + " : " + item->text(5)); diff --git a/src/SeerUtl.h b/src/SeerUtl.h index a299715..f6f9a4f 100644 --- a/src/SeerUtl.h +++ b/src/SeerUtl.h @@ -18,5 +18,5 @@ namespace Seer { unsigned char ucharToAscii (unsigned char byte); int typeBytes (const QString& type); -}; +} diff --git a/src/SeerVariableLoggerBrowserWidget.cpp b/src/SeerVariableLoggerBrowserWidget.cpp index 7507d0c..76e69dc 100644 --- a/src/SeerVariableLoggerBrowserWidget.cpp +++ b/src/SeerVariableLoggerBrowserWidget.cpp @@ -183,6 +183,8 @@ void SeerVariableLoggerBrowserWidget::handleDeleteAllToolButton () { void SeerVariableLoggerBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; item->setToolTip(0, item->text(1) + " : " + item->text(2) + " : " + item->text(3)); diff --git a/src/SeerVariableTrackerBrowserWidget.cpp b/src/SeerVariableTrackerBrowserWidget.cpp index 67e6a0e..710ae40 100644 --- a/src/SeerVariableTrackerBrowserWidget.cpp +++ b/src/SeerVariableTrackerBrowserWidget.cpp @@ -236,6 +236,8 @@ void SeerVariableTrackerBrowserWidget::handleDeleteAllToolButton () { void SeerVariableTrackerBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) { + Q_UNUSED(column); + //qDebug() << item->text(0) << column; item->setToolTip(0, item->text(1) + " : " + item->text(2));