saberbud/seer
1
0
Fork 0
mirror of https://github.com/epasveer/seer.git synced 2026-08-29 16:40:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Clean up code for lint errors.

Browse Source
This commit is contained in:
Ernie Pasveer
2022-04-28 20:20:37 -05:00
parent ce4d4d2b7d
commit e6c15037f9
17 changed files with 44 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/cmake.yml
+6 -2
View File
@@ -28,7 +28,10 @@ jobs:
- name: Where Am I
run: pwd; ls -l
- name: Versions
run: g++ --version
- name: Configure CMake
# Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
@@ -37,6 +40,7 @@ jobs:
- name: Build
# Build your program with the given configuration
run: cd src; cmake --build ${{github.workspace}}/src/build --config ${{env.BUILD_TYPE}} --target seer
- name: Build Result
run: cd src; ls -l build/
src/CMakeLists.txt
+5 -3
View File
@@ -13,9 +13,6 @@ set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTOUIC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_CXX_FLAGS_DEBUG_INIT "-Wall") # Remove if your compiler
set(CMAKE_CXX_FLAGS_RELEASE_INIT "-Wall") # doesn't support the -Wall flag.
find_package(Qt5Core REQUIRED)
find_package(Qt5Gui REQUIRED)
find_package(Qt5Widgets REQUIRED)
@@ -173,6 +170,11 @@ if(NOT CMAKE_BUILD_TYPE MATCHES Debug) #Release, RelWithDebInfo and MinSizeRel
message("System type is" ${SYSTEM_TYPE})
endif()
# for Linux, BSD, Solaris, Minix
if(UNIX AND NOT APPLE)
add_compile_options(-Wall -Wextra -Wunused-result -pedantic -Werror)
endif()
add_compile_definitions(QT_DEPRECATED_WARNINGS)
add_executable(${PROJECT_NAME} ${SYSTEM_TYPE} ${SOURCE_FILES})
src/SeerArrayVisualizerWidget.cpp
+5 -2
View File
@@ -59,7 +59,7 @@ SeerArrayVisualizerWidget::SeerArrayVisualizerWidget (QWidget* parent) : QWidget
QObject::connect(titleLineEdit, &QLineEdit::returnPressed, this, &SeerArrayVisualizerWidget::handleTitleLineEdit);
QObject::connect(pointsCheckBox, &QCheckBox::clicked, this, &SeerArrayVisualizerWidget::handlePointsCheckBox);
QObject::connect(labelsCheckBox, &QCheckBox::clicked, this, &SeerArrayVisualizerWidget::handleLabelsCheckBox);
QObject::connect(lineTypeButtonGroup, QOverload<int>::of(&QButtonGroup::buttonClicked), this, &SeerArrayVisualizerWidget::handleLineTypeButtonGroup);
QObject::connect(lineTypeButtonGroup, QOverload<int>::of(&QButtonGroup::idClicked), this, &SeerArrayVisualizerWidget::handleLineTypeButtonGroup);
// Restore window settings.
readSettings();
@@ -149,7 +149,7 @@ void SeerArrayVisualizerWidget::handleText (const QString& text) {
if (id_text.toInt() == _variableId) {
QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', QString::SkipEmptyParts);
QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', Qt::SkipEmptyParts);
setVariableAddress(words.first());
}
@@ -375,6 +375,9 @@ void SeerArrayVisualizerWidget::resizeEvent (QResizeEvent* event) {
void SeerArrayVisualizerWidget::handleSplitterMoved (int pos, int index) {
Q_UNUSED(pos);
Q_UNUSED(index);
writeSettings();
}
src/SeerDebugDialog.cpp
+1 -1
View File
@@ -33,7 +33,7 @@ SeerDebugDialog::SeerDebugDialog (QWidget* parent) : QDialog(parent) {
QObject::connect(loadBreakpointsFilenameToolButton, &QToolButton::clicked, this, &SeerDebugDialog::handleLoadBreakpointsFilenameToolButton);
QObject::connect(loadCoreFilenameToolButton, &QToolButton::clicked, this, &SeerDebugDialog::handleLoadCoreFilenameToolButton);
QObject::connect(attachProgramPidToolButton, &QToolButton::clicked, this, &SeerDebugDialog::handleProgramPidToolButton);
QObject::connect(_runModeButtonGroup, QOverload<int>::of(&QButtonGroup::buttonClicked), this, &SeerDebugDialog::handleRunModeChanged);
QObject::connect(_runModeButtonGroup, QOverload<int>::of(&QButtonGroup::idClicked), this, &SeerDebugDialog::handleRunModeChanged);
// Set initial run mode.
handleRunModeChanged(-1);
src/SeerEditorWidget.cpp
+3 -3
View File
@@ -230,7 +230,7 @@ void SeerEditorWidget::handleSearchTextLineEdit () {
return;
}
int nMatches = sourceArea()->findText(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags(0)));
int nMatches = sourceArea()->findText(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags()));
matchesLabel->setText(QString("(%1)").arg(nMatches));
}
@@ -243,7 +243,7 @@ void SeerEditorWidget::handleSearchDownToolButton () {
return;
}
sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags(0)));
sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags()));
}
void SeerEditorWidget::handleSearchUpToolButton () {
@@ -254,7 +254,7 @@ void SeerEditorWidget::handleSearchUpToolButton () {
return;
}
sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags(0)) | QTextDocument::FindBackward);
sourceArea()->find(str, (searchMatchCase() ? QTextDocument::FindCaseSensitively : QTextDocument::FindFlags()) | QTextDocument::FindBackward);
}
void SeerEditorWidget::handleSearchCloseToolButton () {
src/SeerGdbConfigPage.cpp
+1 -1
View File
@@ -11,7 +11,7 @@ SeerGdbConfigPage::SeerGdbConfigPage(QWidget* parent) : QWidget(parent) {
// Connect things.
QObject::connect(gdbProgramToolButton, &QToolButton::clicked, this, &SeerGdbConfigPage::handleGdbProgramToolButton);
QObject::connect(styleButtonGroup, QOverload<int>::of(&QButtonGroup::buttonClicked), this, &SeerGdbConfigPage::handleDprintfButtonGroup);
QObject::connect(styleButtonGroup, QOverload<int>::of(&QButtonGroup::idClicked), this, &SeerGdbConfigPage::handleDprintfButtonGroup);
}
SeerGdbConfigPage::~SeerGdbConfigPage() {
src/SeerGdbWidget.cpp
+5 -2
View File
@@ -1454,7 +1454,7 @@ void SeerGdbWidget::handleGdbDataDeleteExpressions (QString expressionids) {
}else{
QStringList ids = expressionids.split(' ', QString::SkipEmptyParts);
QStringList ids = expressionids.split(' ', Qt::SkipEmptyParts);
bool first = true;
for (int i=0; i<ids.size(); i++) {
@@ -1556,6 +1556,9 @@ void SeerGdbWidget::handleGdbArrayVisualizer () {
void SeerGdbWidget::handleSplitterMoved (int pos, int index) {
Q_UNUSED(pos);
Q_UNUSED(index);
//qDebug() << "Splitter moved to " << pos << index;
writeSettings();
@@ -1809,7 +1812,7 @@ void SeerGdbWidget::startGdb () {
_gdbProcess->setProgram(gdbProgram());
// Build the gdb argument list.
QStringList args = gdbArguments().split(' ', QString::SkipEmptyParts);
QStringList args = gdbArguments().split(' ', Qt::SkipEmptyParts);
// Give the gdb process the argument list.
_gdbProcess->setArguments(args);
src/SeerMemoryVisualizerWidget.cpp
+1 -1
View File
@@ -130,7 +130,7 @@ void SeerMemoryVisualizerWidget::handleText (const QString& text) {
if (id_text.toInt() == _variableId) {
QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', QString::SkipEmptyParts);
QStringList words = Seer::filterEscapes(Seer::parseFirst(text, "value=", '"', '"', false)).split(' ', Qt::SkipEmptyParts);
setVariableAddress(words.first());
}
src/SeerRegisterValuesBrowserWidget.cpp
+2
View File
@@ -155,6 +155,8 @@ void SeerRegisterValuesBrowserWidget::refresh () {
void SeerRegisterValuesBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
item->setToolTip(0, item->text(1) + " : " + item->text(2));
src/SeerSourceBrowserWidget.cpp
+2
View File
@@ -144,6 +144,8 @@ void SeerSourceBrowserWidget::handleItemDoubleClicked (QTreeWidgetItem* item, in
void SeerSourceBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
if (item->text(1) == "") { // Look at the FullName.
src/SeerStackArgumentsBrowserWidget.cpp
+2
View File
@@ -123,6 +123,8 @@ void SeerStackArgumentsBrowserWidget::refresh () {
void SeerStackArgumentsBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
if (item->text(0) != "") {
src/SeerStackFramesBrowserWidget.cpp
+2
View File
@@ -183,6 +183,8 @@ void SeerStackFramesBrowserWidget::handleItemDoubleClicked (QTreeWidgetItem* ite
void SeerStackFramesBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
item->setToolTip(0, item->text(0) + " : " + item->text(1) + " : " + item->text(2) + " : " + item->text(3));
src/SeerStackLocalsBrowserWidget.cpp
+2
View File
@@ -209,6 +209,8 @@ void SeerStackLocalsBrowserWidget::handleItemCollapsed (QTreeWidgetItem* item) {
void SeerStackLocalsBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
item->setToolTip(0, item->text(0) + " : " + item->text(2));
src/SeerThreadFramesBrowserWidget.cpp
+2
View File
@@ -212,6 +212,8 @@ void SeerThreadFramesBrowserWidget::handleItemDoubleClicked (QTreeWidgetItem* it
void SeerThreadFramesBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
item->setToolTip(0, item->text(0) + " : " + item->text(1) + " : " + item->text(3) + " : " + item->text(4) + " : " + item->text(5));
src/SeerUtl.h
+1 -1
View File
@@ -18,5 +18,5 @@ namespace Seer {
unsigned char ucharToAscii (unsigned char byte);
int typeBytes (const QString& type);
};
}
src/SeerVariableLoggerBrowserWidget.cpp
+2
View File
@@ -183,6 +183,8 @@ void SeerVariableLoggerBrowserWidget::handleDeleteAllToolButton () {
void SeerVariableLoggerBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
item->setToolTip(0, item->text(1) + " : " + item->text(2) + " : " + item->text(3));
src/SeerVariableTrackerBrowserWidget.cpp
+2
View File
@@ -236,6 +236,8 @@ void SeerVariableTrackerBrowserWidget::handleDeleteAllToolButton () {
void SeerVariableTrackerBrowserWidget::handleItemEntered (QTreeWidgetItem* item, int column) {
Q_UNUSED(column);
//qDebug() << item->text(0) << column;
item->setToolTip(0, item->text(1) + " : " + item->text(2));