diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index d5318ec..76b560d 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -13,6 +13,9 @@ set(CMAKE_AUTOMOC ON) set(CMAKE_AUTOUIC ON) set(CMAKE_AUTORCC ON) +set(CMAKE_CXX_FLAGS_DEBUG_INIT "-Wall") # Remove if your compiler +set(CMAKE_CXX_FLAGS_RELEASE_INIT "-Wall") # doesn't support the -Wall flag. + find_package(Qt5Core REQUIRED) find_package(Qt5Gui REQUIRED) find_package(Qt5Widgets REQUIRED) diff --git a/src/QDetachTabWidget.h b/src/QDetachTabWidget.h index af24909..ba8f30f 100644 --- a/src/QDetachTabWidget.h +++ b/src/QDetachTabWidget.h @@ -5,11 +5,11 @@ struct QDetachTabInfo { - QDetachTabInfo(QString title, QWidget* widget, QWidget* placeholderWidget) : _title(title), _widget(widget), _placeholderWidget(placeholderWidget) {} - + QString _title; QWidget* _widget; QWidget* _placeholderWidget; - QString _title; + + QDetachTabInfo(QString title, QWidget* widget, QWidget* placeholderWidget) : _title(title), _widget(widget), _placeholderWidget(placeholderWidget) {} }; diff --git a/src/SeerArrayVisualizerWidget.cpp b/src/SeerArrayVisualizerWidget.cpp index 0fde6d1..d48461a 100644 --- a/src/SeerArrayVisualizerWidget.cpp +++ b/src/SeerArrayVisualizerWidget.cpp @@ -113,27 +113,22 @@ QString SeerArrayVisualizerWidget::variableName () const { void SeerArrayVisualizerWidget::setVariableAddress (const QString& address) { - unsigned long offset = 0; - bool ok = false; - if (address.startsWith("0x")) { - offset = address.toULong(&ok, 16); + bool ok = false; + + address.toULong(&ok, 16); if (ok == true) { variableAddressLineEdit->setText(address); }else{ variableAddressLineEdit->setText("not an address"); - offset = 0; } }else{ variableAddressLineEdit->setText("not an address"); - offset = 0; } - //qDebug() << address << offset << ok; - arrayTableWidget->setAddressOffset(0); } diff --git a/src/SeerHighlighterSettings.cpp b/src/SeerHighlighterSettings.cpp index b1dcb6e..51d7335 100644 --- a/src/SeerHighlighterSettings.cpp +++ b/src/SeerHighlighterSettings.cpp @@ -15,6 +15,8 @@ SeerHighlighterSettings::~SeerHighlighterSettings () { SeerHighlighterSettings& SeerHighlighterSettings::operator== (const SeerHighlighterSettings& rhs) { _formats = rhs._formats; + + return *this; } QStringList SeerHighlighterSettings::keys () const { diff --git a/src/SeerKeySettings.cpp b/src/SeerKeySettings.cpp index 8034161..077ea99 100644 --- a/src/SeerKeySettings.cpp +++ b/src/SeerKeySettings.cpp @@ -15,6 +15,8 @@ SeerKeySettings::~SeerKeySettings () { SeerKeySettings& SeerKeySettings::operator== (const SeerKeySettings& rhs) { _keys = rhs._keys; + + return *this; } QStringList SeerKeySettings::keys () const { diff --git a/src/build/README.cmake b/src/build/README.cmake index af3a068..58a0b47 100644 --- a/src/build/README.cmake +++ b/src/build/README.cmake @@ -1,9 +1,12 @@ -Notes for cmake. +Notes for building Seer with cmake. % cd seer/src/build -% cmake -DCMAKE_BUILD_TYPE=Debug .. -% cmake -DCMAKE_BUILD_TYPE=Release .. -% make clean -% make -% sudo make install +% cmake -DCMAKE_BUILD_TYPE=Debug .. # Debug release -g. +% cmake -DCMAKE_BUILD_TYPE=Release .. # Optimized release -O. +% cmake -DCMAKE_CXX_FLAGS=-Wall .. # With all compile warnings turned on. +% make clean # Clean files. + +% make seer # Build Seer. + +% sudo make install # Install it.