From 938548625b55e91caa58e5f26bd0c034dcc0dd65 Mon Sep 17 00:00:00 2001 From: ***** <721466+soodoku@users.noreply.github.com> Date: Sun, 26 Jul 2026 20:48:57 -0700 Subject: [PATCH] Fix `make venv` creating the venv at the wrong path ec96f72 introduced the `VENV` variable (default `.venv`) and switched every install and tool invocation to use it, but left the creation line as `python3 -m venv venv`. On a fresh checkout `make venv` therefore creates `venv/` and then fails immediately trying to run `.venv/bin/pip`. Use `${VENV}` on the creation line too. This also makes `VENV` overridable end-to-end, e.g. `make venv VENV=custom-env`, which previously created `venv/` and installed into a directory that did not exist. Co-Authored-By: Claude Opus 5 (1M context) --- CHANGELOG.md | 1 + Makefile | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c62972b..d1d9791 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. The format ### Fixed - Initialize PDFium's form environment in `get_page_image` so that filled AcroForm field content is included when rendering pages via `Page.to_image()`. ([#1367](https://github.com/jsvine/pdfplumber/issues/1367)) +- Fix `make venv`, which created the virtual environment at `venv/` but then installed into `${VENV}` (default `.venv/`), causing the target to fail on a fresh checkout (h/t @soodoku). ([ec96f72](https://github.com/jsvine/pdfplumber/commit/ec96f72)) ## [0.11.10] — 2026-06-14 diff --git a/Makefile b/Makefile index 0d0e6ec..8877e0f 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ VENV ?= .venv PYTHON = ${VENV}/bin/python venv: - python3 -m venv venv + python3 -m venv ${VENV} ${VENV}/bin/pip install --upgrade pip ${VENV}/bin/pip install -r requirements.txt ${VENV}/bin/pip install -r requirements-dev.txt