mirror of
https://github.com/greg7mdp/parallel-hashmap.git
synced 2026-08-30 00:50:38 +08:00
Fix issue #255 - Incorrect concurrent increment of value with std::shared_mutex.
This commit is contained in:
@@ -1,4 +1,52 @@
|
||||
#define THIS_HASH_MAP parallel_flat_hash_map
|
||||
#define THIS_TEST_NAME ParallelFlatHashMap
|
||||
#include <thread>
|
||||
|
||||
#include "parallel_hash_map_test.cc"
|
||||
|
||||
|
||||
#if PHMAP_HAVE_SHARED_MUTEX
|
||||
#include <shared_mutex>
|
||||
|
||||
template <typename K> using HashEqual = phmap::priv::hash_default_eq<K>;
|
||||
template <typename V> using HashFn = phmap::priv::hash_default_hash<V>;
|
||||
template <typename K> using Allocator = phmap::priv::Allocator<K>;
|
||||
|
||||
template <typename K, typename V, size_t N>
|
||||
using parallel_flat_hash_map =
|
||||
phmap::parallel_flat_hash_map<K, V, HashFn<K>, HashEqual<K>,
|
||||
Allocator<phmap::priv::Pair<K, V>>, N,
|
||||
std::shared_mutex>;
|
||||
|
||||
using Table = parallel_flat_hash_map<int, int, 10>;
|
||||
|
||||
TEST(THIS_TEST_NAME, ConcurrencyCheck) {
|
||||
static constexpr int THREADS = 10;
|
||||
static constexpr int EPOCH = 1000;
|
||||
static constexpr int KEY = 12345;
|
||||
|
||||
auto Incr = [](Table *table) {
|
||||
auto exist_fn = [](typename Table::value_type &value) { value.second += 1; };
|
||||
auto emplace_fn = [](const typename Table::constructor &ctor) {
|
||||
ctor(KEY, 1);
|
||||
};
|
||||
for (int i = 0; i < EPOCH; ++i) {
|
||||
(void)table->lazy_emplace_l(KEY, exist_fn, emplace_fn);
|
||||
}
|
||||
};
|
||||
|
||||
Table table;
|
||||
std::vector<std::thread> threads;
|
||||
threads.reserve(THREADS);
|
||||
for (int i = 0; i < THREADS; ++i) {
|
||||
threads.emplace_back([&]() { Incr(&table); });
|
||||
}
|
||||
|
||||
for (auto &thread : threads) {
|
||||
thread.join();
|
||||
}
|
||||
|
||||
EXPECT_EQ(table[KEY], 10000);
|
||||
}
|
||||
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user