enable warning level for for tests (msvc) and cleanup some warnings.

parallel_hashmap/btree.h

@@ -34,6 +34,26 @@
 #ifndef PHMAP_BTREE_BTREE_CONTAINER_H_
 #define PHMAP_BTREE_BTREE_CONTAINER_H_
 
+#ifdef _MSC_VER
+    #pragma warning(push)  
+
+    #pragma warning(disable : 4127) // conditional expression is constant
+    #pragma warning(disable : 4324) // structure was padded due to alignment specifier
+    #pragma warning(disable : 4355) // 'this': used in base member initializer list
+    #pragma warning(disable : 4365) // conversion from 'int' to 'const unsigned __int64', signed/unsigned mismatch
+    #pragma warning(disable : 4514) // unreferenced inline function has been removed
+    #pragma warning(disable : 4623) // default constructor was implicitly defined as deleted
+    #pragma warning(disable : 4625) // copy constructor was implicitly defined as deleted
+    #pragma warning(disable : 4626) // assignment operator was implicitly defined as deleted
+    #pragma warning(disable : 4710) // function not inlined
+    #pragma warning(disable : 4711) //  selected for automatic inline expansion
+    #pragma warning(disable : 4820) // '6' bytes padding added after data member
+    #pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order in braced initializer list
+    #pragma warning(disable : 5026) // move constructor was implicitly defined as deleted
+    #pragma warning(disable : 5027) // move assignment operator was implicitly defined as deleted
+    #pragma warning(disable : 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
+#endif
+
 #include <initializer_list>
 #include <iterator>
 #include <utility>
@@ -67,25 +87,6 @@
     #define PHMAP_META_INTERNAL_STD_CONSTRUCTION_TRAITS_DONT_CHECK_DESTRUCTION 1
 #endif
 
-#ifdef _MSC_VER
-    #pragma warning(push)  
-
-    #pragma warning(disable : 4127) // conditional expression is constant
-    #pragma warning(disable : 4324) // structure was padded due to alignment specifier
-    #pragma warning(disable : 4355) // 'this': used in base member initializer list
-    #pragma warning(disable : 4514) // unreferenced inline function has been removed
-    #pragma warning(disable : 4623) // default constructor was implicitly defined as deleted
-    #pragma warning(disable : 4625) // copy constructor was implicitly defined as deleted
-    #pragma warning(disable : 4626) // assignment operator was implicitly defined as deleted
-    #pragma warning(disable : 4710) // function not inlined
-    #pragma warning(disable : 4711) //  selected for automatic inline expansion
-    #pragma warning(disable : 4820) // '6' bytes padding added after data member
-    #pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order in braced initializer list
-    #pragma warning(disable : 5026) // move constructor was implicitly defined as deleted
-    #pragma warning(disable : 5027) // move assignment operator was implicitly defined as deleted
-    #pragma warning(disable : 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
-#endif
-
 namespace phmap {
 
     // Defined and documented later on in this file.

parallel_hashmap/phmap.h

@@ -33,6 +33,24 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 // ---------------------------------------------------------------------------
+
+#ifdef _MSC_VER
+    #pragma warning(push)  
+
+    #pragma warning(disable : 4127) // conditional expression is constant
+    #pragma warning(disable : 4324) // structure was padded due to alignment specifier
+    #pragma warning(disable : 4514) // unreferenced inline function has been removed
+    #pragma warning(disable : 4623) // default constructor was implicitly defined as deleted
+    #pragma warning(disable : 4625) // copy constructor was implicitly defined as deleted
+    #pragma warning(disable : 4626) // assignment operator was implicitly defined as deleted
+    #pragma warning(disable : 4710) // function not inlined
+    #pragma warning(disable : 4711) // selected for automatic inline expansion
+    #pragma warning(disable : 4820) // '6' bytes padding added after data member
+    #pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order in braced initializer list
+    #pragma warning(disable : 5027) // move assignment operator was implicitly defined as deleted
+    #pragma warning(disable : 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
+#endif
+
 #include <algorithm>
 #include <cmath>
 #include <cstring>
@@ -54,23 +72,6 @@
     #include <string_view>
 #endif
 
-#ifdef _MSC_VER
-    #pragma warning(push)  
-
-    #pragma warning(disable : 4127) // conditional expression is constant
-    #pragma warning(disable : 4324) // structure was padded due to alignment specifier
-    #pragma warning(disable : 4514) // unreferenced inline function has been removed
-    #pragma warning(disable : 4623) // default constructor was implicitly defined as deleted
-    #pragma warning(disable : 4625) // copy constructor was implicitly defined as deleted
-    #pragma warning(disable : 4626) // assignment operator was implicitly defined as deleted
-    #pragma warning(disable : 4710) // function not inlined
-    #pragma warning(disable : 4711) //  selected for automatic inline expansion
-    #pragma warning(disable : 4820) // '6' bytes padding added after data member
-    #pragma warning(disable : 4868) // compiler may not enforce left-to-right evaluation order in braced initializer list
-    #pragma warning(disable : 5027) // move assignment operator was implicitly defined as deleted
-    #pragma warning(disable : 5045) // Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
-#endif
-
 namespace phmap {
 
 namespace container_internal {

parallel_hashmap/phmap_fwd_decl.h

@@ -11,6 +11,13 @@
 //      https://www.apache.org/licenses/LICENSE-2.0
 // ---------------------------------------------------------------------------
 
+#ifdef _MSC_VER
+    #pragma warning(push)  
+    #pragma warning(disable : 4514) // unreferenced inline function has been removed
+    #pragma warning(disable : 4710) // function not inlined
+    #pragma warning(disable : 4711) // selected for automatic inline expansion
+#endif
+
 #include <memory>
 #include <utility>
 #include <functional>
@@ -140,4 +147,8 @@ namespace phmap {
 }  // namespace phmap
 
 
+#ifdef _MSC_VER
+     #pragma warning(pop)  
+#endif
+
 #endif // phmap_fwd_decl_h_guard_

parallel_hashmap/phmap_utils.h

@@ -21,16 +21,18 @@
 // limitations under the License.
 // ---------------------------------------------------------------------------
 
+#ifdef _MSC_VER
+    #pragma warning(push)  
+    #pragma warning(disable : 4514) // unreferenced inline function has been removed
+    #pragma warning(disable : 4710) // function not inlined
+    #pragma warning(disable : 4711) // selected for automatic inline expansion
+#endif
+
 #include <cstdint>
 #include <functional>
 #include <tuple>
 #include "phmap_bits.h"
 
-#ifdef _MSC_VER
-    #pragma warning(push)  
-    #pragma warning(disable : 4514) // unreferenced inline function has been removed
-#endif
-
 namespace phmap
 {