From 17f90489903aa63874f55538e70cd732ef185d21 Mon Sep 17 00:00:00 2001 From: greg Date: Fri, 7 Aug 2020 13:10:31 -0400 Subject: [PATCH] change mutable if_contains to modify_if --- parallel_hashmap/phmap.h | 2 +- tests/parallel_hash_map_test.cc | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/parallel_hashmap/phmap.h b/parallel_hashmap/phmap.h index cd98170..6ca41ad 100644 --- a/parallel_hashmap/phmap.h +++ b/parallel_hashmap/phmap.h @@ -3438,7 +3438,7 @@ public: } template - bool if_contains(const key_arg& key, F&& f) { + bool modify_if(const key_arg& key, F&& f) { #if __cplusplus >= 201703L static_assert(std::is_invocable::value); #endif diff --git a/tests/parallel_hash_map_test.cc b/tests/parallel_hash_map_test.cc index 662a949..48241eb 100644 --- a/tests/parallel_hash_map_test.cc +++ b/tests/parallel_hash_map_test.cc @@ -23,8 +23,10 @@ TEST(THIS_TEST_NAME, ThreadSafeContains) { EXPECT_FALSE(m.if_contains(3, get_value)); auto set_value = [&val](int& v) { v = 11; }; - EXPECT_TRUE(m.if_contains(2, set_value)); + EXPECT_TRUE(m. modify_if(2, set_value)); EXPECT_EQ(m[2], 11); + + EXPECT_FALSE(m.modify_if(3, set_value)); } } // namespace