mirror of
https://github.com/ceres-solver/ceres-solver.git
synced 2026-08-29 16:40:38 +08:00
Sergiu Deitsch
388c142866
With -flto=auto, GCC emits multiple warnings in release builds such as
In function ‘make_unique’,
inlined from ‘Create’ at ceres-solver/internal/ceres/scratch_evaluate_preparer.cc:43:75,
inlined from ‘CreateEvaluatePreparers’ at ceres-solver/internal/ceres/compressed_row_jacobian_writer.h:95:66,
inlined from ‘__ct ’ at ceres-solver/internal/ceres/program_evaluator.h:120:9,
inlined from ‘Evaluate.constprop.isra’ at ceres-solver/internal/ceres/problem_impl.cc:695:65:
/usr/include/c++/12.1.1/bits/unique_ptr.h:1080:30: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
1080 | { return unique_ptr<_Tp>(new remove_extent_t<_Tp>[__num]()); }
| ^
because a signed integer is used to specify the size of allocated arrays
instead of the expected unsigned (specifically, std::size_t) without
checking for negative values at the call site.
Change-Id: I923b1d074241535426bfea041568ef1dc7f3ec86
73 lines
3.0 KiB
C++
73 lines
3.0 KiB
C++
// Ceres Solver - A fast non-linear least squares minimizer
|
|
// Copyright 2022 Google Inc. All rights reserved.
|
|
// http://ceres-solver.org/
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above copyright notice,
|
|
// this list of conditions and the following disclaimer in the documentation
|
|
// and/or other materials provided with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its contributors may be
|
|
// used to endorse or promote products derived from this software without
|
|
// specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
// POSSIBILITY OF SUCH DAMAGE.
|
|
//
|
|
// Author: keir@google.com (Keir Mierle)
|
|
//
|
|
// A scratch evaluate preparer provides temporary storage for the jacobians that
|
|
// are created when running user-provided cost functions. The evaluator takes
|
|
// care to avoid evaluating the jacobian for fixed parameters.
|
|
|
|
#ifndef CERES_INTERNAL_SCRATCH_EVALUATE_PREPARER_H_
|
|
#define CERES_INTERNAL_SCRATCH_EVALUATE_PREPARER_H_
|
|
|
|
#include <memory>
|
|
|
|
#include "ceres/internal/disable_warnings.h"
|
|
#include "ceres/internal/export.h"
|
|
|
|
namespace ceres::internal {
|
|
|
|
class Program;
|
|
class ResidualBlock;
|
|
class SparseMatrix;
|
|
|
|
class CERES_NO_EXPORT ScratchEvaluatePreparer {
|
|
public:
|
|
// Create num_threads ScratchEvaluatePreparers.
|
|
static std::unique_ptr<ScratchEvaluatePreparer[]> Create(
|
|
const Program& program, unsigned num_threads);
|
|
|
|
// EvaluatePreparer interface
|
|
void Init(int max_derivatives_per_residual_block);
|
|
void Prepare(const ResidualBlock* residual_block,
|
|
int residual_block_index,
|
|
SparseMatrix* jacobian,
|
|
double** jacobians);
|
|
|
|
private:
|
|
// Scratch space for the jacobians; each jacobian is packed one after another.
|
|
// There is enough scratch to hold all the jacobians for the largest residual.
|
|
std::unique_ptr<double[]> jacobian_scratch_;
|
|
};
|
|
|
|
} // namespace ceres::internal
|
|
|
|
#include "ceres/internal/reenable_warnings.h"
|
|
|
|
#endif // CERES_INTERNAL_SCRATCH_EVALUATE_PREPARER_H_
|