mirror of
https://github.com/ceres-solver/ceres-solver.git
synced 2026-08-29 16:40:38 +08:00
19ab2c1793
1. Add threading to all three subclasses of BlockRandomAccessMatrix. i.e. BlockRandomAccessDenseMatrix, BlockRandomAccessSparseMatrix and BlockRandomAccessDenseMatrix. For BlockRandomAccessDenseMatrix and BlockRandomAccessSparseMatrix this just means SetZero is parallelized. Which by itself is no big deal, but by doing so, the constructor for all three subclasses become uniform. BlockRandomAccessSparseMatrix::SymmetricRightMultiplyAndAccumulate maybe threaded in the future if needed. BlockRandomAccessDiagonalMatrix is the biggest beneficiary. SetZero Invert and RightMultiplyAndAccumulate are all threaded now. 2. Change the storage in BlockRandomAccessDiagonalMatrix from TripletSparseMatrix to CompressedRowSparseMatrix. This has no performance implications since we do not really use the capabilities of the underlying matrix indexing representation. This is a forward looking change when we decide to transfer this matrix to the GPU, a CompressedRowSparseMatrix will save on a data conversion. 3. Use std::unique_ptr as needed and eliminate the need for custom destructors. 4. Modify CompressedRowSparseMatrix::CreateBlockDiagonalMatrix to take a nullptr as the data vector. Fixes https://github.com/ceres-solver/ceres-solver/issues/936 Fixes https://github.com/ceres-solver/ceres-solver/issues/935 Change-Id: Ia6487f2d924fbe669835bdcc38abf2b451bda4ee
183 lines
6.3 KiB
C++
183 lines
6.3 KiB
C++
// Ceres Solver - A fast non-linear least squares minimizer
|
|
// Copyright 2015 Google Inc. All rights reserved.
|
|
// http://ceres-solver.org/
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above copyright notice,
|
|
// this list of conditions and the following disclaimer in the documentation
|
|
// and/or other materials provided with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its contributors may be
|
|
// used to endorse or promote products derived from this software without
|
|
// specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
// POSSIBILITY OF SUCH DAMAGE.
|
|
//
|
|
// Author: sameeragarwal@google.com (Sameer Agarwal)
|
|
|
|
#include "ceres/block_random_access_sparse_matrix.h"
|
|
|
|
#include <limits>
|
|
#include <memory>
|
|
#include <set>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "ceres/internal/eigen.h"
|
|
#include "glog/logging.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace ceres::internal {
|
|
|
|
TEST(BlockRandomAccessSparseMatrix, GetCell) {
|
|
ContextImpl context;
|
|
constexpr int num_threads = 1;
|
|
std::vector<Block> blocks;
|
|
blocks.emplace_back(3, 0);
|
|
blocks.emplace_back(4, 3);
|
|
blocks.emplace_back(5, 7);
|
|
constexpr int num_rows = 3 + 4 + 5;
|
|
|
|
std::set<std::pair<int, int>> block_pairs;
|
|
int num_nonzeros = 0;
|
|
block_pairs.emplace(0, 0);
|
|
num_nonzeros += blocks[0].size * blocks[0].size;
|
|
|
|
block_pairs.emplace(1, 1);
|
|
num_nonzeros += blocks[1].size * blocks[1].size;
|
|
|
|
block_pairs.emplace(1, 2);
|
|
num_nonzeros += blocks[1].size * blocks[2].size;
|
|
|
|
block_pairs.emplace(0, 2);
|
|
num_nonzeros += blocks[2].size * blocks[0].size;
|
|
|
|
BlockRandomAccessSparseMatrix m(blocks, block_pairs, &context, num_threads);
|
|
EXPECT_EQ(m.num_rows(), num_rows);
|
|
EXPECT_EQ(m.num_cols(), num_rows);
|
|
|
|
for (const auto& block_pair : block_pairs) {
|
|
const int row_block_id = block_pair.first;
|
|
const int col_block_id = block_pair.second;
|
|
int row;
|
|
int col;
|
|
int row_stride;
|
|
int col_stride;
|
|
CellInfo* cell = m.GetCell(
|
|
row_block_id, col_block_id, &row, &col, &row_stride, &col_stride);
|
|
EXPECT_TRUE(cell != nullptr);
|
|
EXPECT_EQ(row, 0);
|
|
EXPECT_EQ(col, 0);
|
|
EXPECT_EQ(row_stride, blocks[row_block_id].size);
|
|
EXPECT_EQ(col_stride, blocks[col_block_id].size);
|
|
|
|
// Write into the block
|
|
MatrixRef(cell->values, row_stride, col_stride)
|
|
.block(row, col, blocks[row_block_id].size, blocks[col_block_id].size) =
|
|
(row_block_id + 1) * (col_block_id + 1) *
|
|
Matrix::Ones(blocks[row_block_id].size, blocks[col_block_id].size);
|
|
}
|
|
|
|
const TripletSparseMatrix* tsm = m.matrix();
|
|
EXPECT_EQ(tsm->num_nonzeros(), num_nonzeros);
|
|
EXPECT_EQ(tsm->max_num_nonzeros(), num_nonzeros);
|
|
|
|
Matrix dense;
|
|
tsm->ToDenseMatrix(&dense);
|
|
|
|
double kTolerance = 1e-14;
|
|
|
|
// (0, 0)
|
|
EXPECT_NEAR(
|
|
(dense.block(0, 0, 3, 3) - Matrix::Ones(3, 3)).norm(), 0.0, kTolerance);
|
|
// (1, 1)
|
|
EXPECT_NEAR((dense.block(3, 3, 4, 4) - 2 * 2 * Matrix::Ones(4, 4)).norm(),
|
|
0.0,
|
|
kTolerance);
|
|
// (1, 2)
|
|
EXPECT_NEAR((dense.block(3, 3 + 4, 4, 5) - 2 * 3 * Matrix::Ones(4, 5)).norm(),
|
|
0.0,
|
|
kTolerance);
|
|
// (0, 2)
|
|
EXPECT_NEAR((dense.block(0, 3 + 4, 3, 5) - 3 * 1 * Matrix::Ones(3, 5)).norm(),
|
|
0.0,
|
|
kTolerance);
|
|
|
|
// There is nothing else in the matrix besides these four blocks.
|
|
EXPECT_NEAR(
|
|
dense.norm(), sqrt(9. + 16. * 16. + 36. * 20. + 9. * 15.), kTolerance);
|
|
|
|
Vector x = Vector::Ones(dense.rows());
|
|
Vector actual_y = Vector::Zero(dense.rows());
|
|
Vector expected_y = Vector::Zero(dense.rows());
|
|
|
|
expected_y += dense.selfadjointView<Eigen::Upper>() * x;
|
|
m.SymmetricRightMultiplyAndAccumulate(x.data(), actual_y.data());
|
|
EXPECT_NEAR((expected_y - actual_y).norm(), 0.0, kTolerance)
|
|
<< "actual: " << actual_y.transpose() << "\n"
|
|
<< "expected: " << expected_y.transpose() << "matrix: \n " << dense;
|
|
}
|
|
|
|
// IntPairToLong is private, thus this fixture is needed to access and
|
|
// test it.
|
|
class BlockRandomAccessSparseMatrixTest : public ::testing::Test {
|
|
public:
|
|
void SetUp() final {
|
|
std::vector<Block> blocks;
|
|
blocks.emplace_back(1, 0);
|
|
std::set<std::pair<int, int>> block_pairs;
|
|
block_pairs.emplace(0, 0);
|
|
m_ = std::make_unique<BlockRandomAccessSparseMatrix>(
|
|
blocks, block_pairs, &context_, 1);
|
|
}
|
|
|
|
void CheckIntPairToLong(int a, int b) {
|
|
int64_t value = m_->IntPairToLong(a, b);
|
|
EXPECT_GT(value, 0) << "Overflow a = " << a << " b = " << b;
|
|
EXPECT_GT(value, a) << "Overflow a = " << a << " b = " << b;
|
|
EXPECT_GT(value, b) << "Overflow a = " << a << " b = " << b;
|
|
}
|
|
|
|
void CheckLongToIntPair() {
|
|
uint64_t max_rows = m_->kMaxRowBlocks;
|
|
for (int row = max_rows - 10; row < max_rows; ++row) {
|
|
for (int col = 0; col < 10; ++col) {
|
|
int row_computed;
|
|
int col_computed;
|
|
m_->LongToIntPair(
|
|
m_->IntPairToLong(row, col), &row_computed, &col_computed);
|
|
EXPECT_EQ(row, row_computed);
|
|
EXPECT_EQ(col, col_computed);
|
|
}
|
|
}
|
|
}
|
|
|
|
private:
|
|
ContextImpl context_;
|
|
std::unique_ptr<BlockRandomAccessSparseMatrix> m_;
|
|
};
|
|
|
|
TEST_F(BlockRandomAccessSparseMatrixTest, IntPairToLongOverflow) {
|
|
CheckIntPairToLong(std::numeric_limits<int>::max(),
|
|
std::numeric_limits<int>::max());
|
|
}
|
|
|
|
TEST_F(BlockRandomAccessSparseMatrixTest, LongToIntPair) {
|
|
CheckLongToIntPair();
|
|
}
|
|
|
|
} // namespace ceres::internal
|