mirror of
https://github.com/ceres-solver/ceres-solver.git
synced 2026-08-30 00:50:37 +08:00
Sergey Sharybin
54ba6c27b5
This commit includes the following: - Changes to CMake to make it safer to see which compiler flags are supported, so this way we do not need to worry about version checks in CMake. - Unix platforms (which includes both Linux and Apple as far as i can tell) will now enable -Wmissing-declarations warning for the whole Ceres. - Changes in all sources to solve missing declaration warning. In most cases it was either matter of using static qualifier or moving functions to an anonymous namespace. In one case the function got removed, since it seems to be unused. Additionally, in slam examples there was a non-inlined function implementation in a header, which is a direct way to cause linking errors if other .cc file will include that helper header. - All third party sources (which is currently only gmock) has this extra paranoid warning disabled. This warning is important in the following cases: - Detect helper functions which are not needed anymore. - Avoid unnoticed pollution of namespace. - Avoid bad level calls. - Avoid missing updates in header files after changes in implementation file. - Helps integrating Ceres into software where paranoid warnings are important. Change-Id: I9b1044aced3910d8c6b2356cfe2bf57f3c8c58db