mirror of
https://github.com/ceres-solver/ceres-solver.git
synced 2026-08-30 00:50:37 +08:00
Sergiu Deitsch
4893392195
Previously, MSVC warning C4996 was suppressed unconditionally in the entire code base which made it difficult identifying and fixing specific problems, particularly those in the public interface. Prefer now to disable warnings at the specific location they occur. This approach, however, reveals an inconsistency in how Ceres handles POSIX functions which are declared deprecated by MSVC. Specifically, Bessel functions use the underscore form whereas the read function does not. To simplify the logic, we revert to POSIX compatible functions. C++23 also deprecates std::numeric_limits<T>::has_denorm which MSVC warns about. Here, we disable the deprecation warning locally to avoid the warning leaking into the user code. Fixes #1013 Change-Id: Ida8457cc8dd8770b4384a7c49d16f213b02cdec4