Commit Graph

173 Commits

Author SHA1 Message Date
Alex Stewart ec6bfa5b12 Compile miniglog into Ceres if enabled on all platforms.
- Previously if miniglog was being used (on a non-Android system), we
  compiled it into a separate library, against which Ceres then linked.
- This was unsatisfactory as it required miniglog being built as a
  static library when building Ceres as a Windows DLL, because miniglog
  did not use the dllexport/dllimport statements, whilst for other
  platforms when building Ceres as a shared library, miniglog needed to
  be compiled as a shared library.

- We now compile miniglog into Ceres on all platforms, not just on
  Android.
- miniglog now uses the CERES_EXPORT macro to support Windows DLLs.
  This means that miniglog now depends on Ceres' internal/port.h (and
  thus internal/config.h) which define the CERES_EXPORT macro and
  control its behaviour respectively.
- miniglog now also uses localtime_s, not localtime on Windows.

Change-Id: Ia55b9af8b4e6decf067eab92f0a5c2d14358a1e9
2014-06-09 19:02:07 +00:00
Sameer Agarwal 4fce29c29e Documentation update.
Update the documentation to reflect the new trust region solver
logging style.

Change-Id: Id2d6b9efeee86c690c349a225d344e9f97ddbcdf
2014-06-06 05:02:07 +00:00
Sameer Agarwal d54e98777f Add a note about git commit message style.
Update contributing.rst to point to Tim Pope's suggestions
for how to write git commit messages.

Change-Id: Idcbece3e7576f54794d8a107aa2c5aa48dc4ddf7
2014-06-05 19:10:19 +00:00
Sameer Agarwal c8063df917 POLAK_RIBIRERE -> POLAK_RIBIERE
Thanks to Vladimir Chalupecky for reporting this.

Change-Id: I2e419415394f5d2be35b825d7c777b01ff31add1
2014-06-03 20:30:15 -07:00
Sameer Agarwal 1693645a67 Add Solver::Options::IsValid.
This provides a user visible way to validate the Solver::Options
before calling Solve.

Change-Id: Ife84fd33532ab2ccb7ac95abe22735843db51fde
2014-05-30 13:00:18 -07:00
Alex Stewart 1c4b48afae Fixing missing Sphinx formatting for parameter bound methods.
Change-Id: I0364cd284355d6284e0836a120417c5f0c7a78fe
2014-05-30 16:42:43 +01:00
Sameer Agarwal b766177bab Remove support for Solver::Options::solver_log.
This is not really used and if needed can be implemented
in user code.

Change-Id: I56328d51c9d3788f90c751ff9c3a5937989f6ee0
2014-05-29 21:59:37 +00:00
Sameer Agarwal 9a022f601b Fix a typo in index.rst
Thanks to Pierre Moulon for pointing this out.

Change-Id: I1e0021b613e57e9f0c13db4634662ee3e1e22aa9
2014-05-27 23:58:02 -07:00
Sameer Agarwal 451e71c6b7 Prepare for version 1.9.0
1. Update ceres-solver.spec with version bump
   and a new package description.
2. Update the docs to refer to 1.9.0
3. Update version history.
4. Change build requirements for Android to be r9d.

Change-Id: Ibab27976b214a11549cb2688b91f791a6388b0b5
2014-05-27 11:39:07 -07:00
Alex Stewart 9febb5f2ef Updating docs to include Windows options for SuiteSparse.
- A number of users are now successfully using the
  suitesparse-metis-for-windows project to build Ceres with SuiteSparse
  on Windows.
- Also fixing missing requirement for sphinx_rdm_theme if building
  the Ceres docs.

Change-Id: I1a36c13166f96743557de2ac3b7c9b84531d1f24
2014-05-27 13:26:10 +00:00
Keir Mierle d0f194a454 Tweak iOS build instructions
Change-Id: I05a8e46f6db0eb5914f88a04dca90dec4441b5c1
2014-05-27 06:32:41 +00:00
Alex Stewart 1bc7b38ac1 Support user passing a custom CMAKE_MODULE_PATH (for BLAS / LAPACK).
- Previously we set CMAKE_MODULE_PATH explicitly rather than appending
  to it when adding our local cmake directory.
- This meant the user could not easily pass their own directory which
  would also be used.  This would be useful if they had their own
  custom FindBLAS / FindLAPACK scripts that they wanted to overload
  the defaults shipped with CMake.

Change-Id: I0c1fda1b6fd81eab68755aa036f64af3efbb226d
2014-05-26 19:54:03 +01:00
Keir Mierle 6a9367711f Tweak build dependencies in the documentation
Change-Id: Ice4cc42bbcf00dafb66785fc96a048618a0b834f
2014-05-23 01:53:18 +00:00
Keir Mierle 4425473ef5 Fix formatting in building docs
Change-Id: I75aa4f12733462d592775b4df766c05c50f20b60
2014-05-23 01:00:22 +00:00
Sameer Agarwal 8c62487e43 Preparations for 1.9.0 release.
Version bump.
minor docs update.

Change-Id: I2fbe20ba4af6b2e186fe244c96ce6d6464fe0469
2014-05-16 09:48:41 -07:00
Sameer Agarwal 0831275a78 Documentation update.
1. Update iOS build instructions.
2. Update version history.

Change-Id: I49d62e86ecff39190b50c050cb12eef4e2773357
2014-05-16 08:32:23 -07:00
Sameer Agarwal 1c089e8453 Notational fix in modeling.rst by William Rucklidge.
Change-Id: Iffa127541380fcc32da13fe4ac474692e1e3d0ec
2014-05-13 16:58:25 -07:00
Sameer Agarwal a97056c975 Various documentation fixes from William Rucklidge.
Change-Id: I102e98f41f4b5fe2a84d1224d5ed7517fdfdb022
2014-05-13 16:45:36 -07:00
Sameer Agarwal 8f4dcb25f1 Documentation update.
Update modeling.rst and solving.rst to reflect
changes to the API.

Change-Id: Id1a8adfed1486f08e5fd67c5af2d29708a26490c
2014-05-13 12:31:30 -07:00
Sameer Agarwal af3154422b Add Alex Stewart as a maintainer.
Update contributing.rst to mention Alex
as one of the people who can be added
as a reviewer.

Change-Id: I30ff3e635e8c419e11e8f20394aaea5f284a10d5
2014-05-09 16:10:55 +00:00
Alex Stewart ea76585068 Adding autogenerated Ceres config.h to #define Ceres compile options.
- Previously we passed all compile options to Ceres via add_definitions
  in CMake.  This was fine for private definitions (used only by Ceres)
  but required additional work for public definitions to ensure they
  were correctly propagated to clients via CMake using
  target_compile_definitions() (>= 2.8.11) or add_definitions().
- A drawback to these approaches is that they did not work for chained
  dependencies on Ceres, as in if in the users project B <- A <- Ceres,
  then although the required Ceres public compile definitions would
  be used when compiling A, they would not be propagated to B.

- This patch replaces the addition of compile definitions via
  add_definitions() with an autogenerated config.h header which
  is installed with Ceres and defines all of the enabled Ceres compile
  options.
- This removes the need for the user to propagate any compile
  definitions in their projects, and additionally allows post-install
  inspect of the options with which Ceres was compiled.

Change-Id: Idbdb6abdad0eb31e7540370e301afe87a07f2260
2014-05-09 10:57:31 +01:00
Sameer Agarwal 31b5037926 Lint cleanup from William Rucklidge.
Change-Id: If545f114c1a2b07edd660a3c71ecfc16ffa25e43
2014-04-30 15:02:38 -07:00
Sameer Agarwal b1668067f1 Variety of changes to documentation and example code.
1. Update version history.
2. Minor changes to the tutorial to reflect the bounds constrained
   problem.
3. Added static factory methods to the SnavelyReprojectionError.
4. Removed relative gradient tolerance from types.h as it is
   not true anymore.

Change-Id: I8de386e5278a008c84ef2d3290d2c4351417a9f1
2014-04-29 09:09:00 -07:00
Björn Piltz 5d7eed87b4 Suppport for MSVC DLLs.
Change-Id: Ibbcc4ba4e59f5bbf1cb91fe81c7d3b9042d03493
2014-04-28 19:56:24 +00:00
Sameer Agarwal cc9d3bba10 Remove a comment from conf.py
Change-Id: I675f7e8fc5dd2143eab74901bc7241e02e37285f
2014-04-18 22:58:09 -07:00
Sameer Agarwal c4cd29dd7c Merge landing page with introduction.
The existing introduction was a bit redundant and also
was not really an introduction. Also updated the build
instructions to reflect the new reality on Mac OSX.

Also updated the beginning of the tutorial to be a bit
gentler and updated the history to be more consistent

Change-Id: Ife38c1949252cf9f4c6301856957f2d38365f313
2014-04-16 23:40:12 -07:00
Sameer Agarwal 7d489fdb07 Refactor the landing page to be a bit more compact.
Also minor changes to the introduction.

Change-Id: Iaa71f576b95c869f075d6837dbb60ba4bb608ee7
2014-04-07 11:45:53 -07:00
Keir Mierle 406ac78167 Rework Ceres documentation as new website
This reworks the Ceres Sphinx documentation such that it can
function as the main Ceres website, now hosted at
ceres-solver.org. This also changes to the theme sphinx_rtd_theme
used by Read The Docs; this theme has strong mobile support and is
well enough designed.

Change-Id: I63232d985859a6dac94ff58f08bf81eb2b9e7f99
2014-04-07 15:28:21 +00:00
Sameer Agarwal 75e2232b29 Fix spacing in building.rst
Change-Id: I4c68d732c80d7ff2bdbc812bf0b7c7fb98c43957
2014-03-28 11:21:02 -07:00
Richard Bowen b555b489b8 Changes documentation to reflect changes in output format.
Change-Id: Ic0ba234283e791edcad29aec067905dcb2130813
2014-03-27 15:51:58 -07:00
Alex Stewart 195e49351b Check validity of residual block before removal in RemoveResidualBlock.
- Breaking change: Problem::Options::enable_fast_parameter_block_removal
  is now Problem::Options::enable_fast_removal, as it now controls
  the behaviour for both parameter and residual blocks.

- Previously we did not check that the specified residual block to
  remove in RemoveResidualBlock actually represented a valid residual
  for the problem.
- This meant that Ceres would die unexpectedly if the user passed an
  uninitialised residual_block, or more likely attempted to remove a
  residual block that had already been removed automatically after
  the user removed a parameter block upon on which it was dependent.
- RemoveResidualBlock now verifies the validity of the given
  residual_block to remove.  Either by checking against a hash set of
  all residuals maintained in ProblemImpl iff enable_fast_removal
  is enabled.  Or by a full scan of the residual blocks if not.

Change-Id: I9ab178e2f68a74135f0a8e20905b16405c77a62b
2014-03-26 17:49:36 +00:00
Sameer Agarwal 4f603fb0d8 Grammer fixes from William Rucklidge.
Change-Id: Ia40df7a1d141eb2552694510453d1431bb0c8dce
2014-03-19 17:16:43 -07:00
Sameer Agarwal efab1ab989 Rename tricks.rst to faq.rst.
Reorganize into sections and add some advice on
linear solvers.

Change-Id: Ia2d8665720c64b17da67f466f2fc154efb2b6c50
2014-03-14 15:03:15 -07:00
Sameer Agarwal ee21fac049 More tips and tricks.
1. Add a tip about glog.
2. Add a tip about using Summary::FullReport to optimize performance.
3. Add a tip about using the Inverse Function Theorem.

Change-Id: I949ec6843ff796672edbad8bc801230dd0ab5345
2014-03-13 17:48:00 -07:00
Sameer Agarwal 5f3f4007b9 Extend the advice on derivatives.
Extend the tips/tricks section to include more comprehensive
advice on derivatives.

Change-Id: Iba5768055b32a65e36d70e6f4db62eca9b331253
2014-03-11 16:11:51 -07:00
Sameer Agarwal 58b1e1b53d Add a tips/tricks/FAQ section to the documentation.
This is just a very bare bones beginning to this chapter.
But it opens the door to actually adding content to this
one tip/trick at a time.

Change-Id: I2aa386ba4da66dba5308e3f4ed4d434e44e44fd9
2014-03-11 12:15:09 -07:00
Sameer Agarwal 879fc2827a Remove CERES_NO_LINE_SEARCH_MINIMIZER.
Now that the trust region minimizer depends on the line search
minimizer, conditional compilation of the line search minimizer
will lead to build breakages, so this option is now not available.

It is not expected to have as significant impact on users as the
amount of code in the line search minimization algorithm is
rather small to begin with.

Change-Id: I2aa6b6e6e3931b6428dbda654f14faf1ac6dd130
2014-02-25 11:35:54 -08:00
Sameer Agarwal 9b83e49e54 Fix a small typo in solving.rst
Change-Id: Ib0b19d329a64230629b16e71437cdb53f10e551d
2014-02-25 11:33:18 -08:00
Sameer Agarwal 9bd23f29e8 Update documentation.
1. Reflect the demise of the various FOO_TOLERANCE convergence
types.

2. Update the documentation for Solver::Options::gradient_tolerance.

Change-Id: I6bd11d260d6f8a3222b6a41a62dc4943ec8fcfbf
2014-02-24 22:30:21 -08:00
Sameer Agarwal 85561eee95 Use int32 for parameter block sizes.
CostFunction now uses int32 instead of int16
to store the size of its parameter blocks.

This is an API breaking change.

Change-Id: I032ea583bc7ea4b3009be25d23a3be143749c73e
2014-01-07 22:22:14 -08:00
Sameer Agarwal dcee120bac Consolidate SolverTerminationType enum.
1. Rename SolverTerminationType to TerminationType.
2. Consolidate the enum as
  a. CONVERGENCE - subsumes FUNCTION_TOLERANCE, PARAMETER_TOLERANCE and GRADIENT_TOLERANCE
  b. NO_CONVERGENCE
  c. FAILURE - captures all kinds of failures including DID_NOT_RUN.
  d. USER_SUCCESS
  e. USER_FAILURE
3. Solver::Summary::error is renamed to be Solver::Summary::message, to both
reduce confusion as well as capture its true meaning.

Change-Id: I27a382e66e67f5a4750d0ee914d941f6b53c326d
2013-12-17 11:21:33 -08:00
Sameer Agarwal ed92366592 Lint cleanup from William Rucklidge.
Change-Id: I745810f5496a1b93263b20ff140f8883da61995e
2013-11-28 07:02:03 -08:00
Sameer Agarwal 6c0d96424e Minor documentation fix.
Thanks to Satya Mallick.

Change-Id: I556f1c141bf16739d54450351b0f29fd4ea40014
2013-11-20 11:52:01 -08:00
Sameer Agarwal 7747bb0e6b Minor corrections to the documentation.
Thanks to Satya Mallick for reporting these.

Change-Id: Ia52e08a7e21d5247dc475cfbf10bf57265aa118f
2013-11-20 11:31:10 -08:00
Sameer Agarwal 1a041c35b7 Update to 1.8.0.
Change-Id: Id42e594f03e3575d06e18c1ef66df64f43d86839
2013-11-12 14:19:25 -08:00
Sameer Agarwal 9ba0b352a2 Lint and other cleanups from William Rucklidge
Change-Id: I7fb23c2db85f0f121204560b79f1966f3d584431
2013-11-05 13:04:56 -08:00
Sameer Agarwal c71085ed32 Update to 1.8.0rc1.
Change-Id: Iaa10fd5a20be2ef84aca0119306c44669d87cc5d
2013-10-31 14:07:18 -07:00
Sameer Agarwal f06b9face5 Add support for multiple visibility clustering algorithms.
The original visibility based preconditioning paper and
implementation only used the canonical views algorithm.

This algorithm for large dense graphs can be particularly
expensive. As its worst case complexity is cubic in size
of the graph.

Further, for many uses the SCHUR_JACOBI preconditioner
was both effective enough while being cheap. It however
suffers from a fatal flaw. If the camera parameter blocks
are split between two or more parameter blocks, e.g,
extrinsics and intrinsics. The preconditioner because
it is block diagonal will not capture the interactions
between them.

Using CLUSTER_JACOBI or CLUSTER_TRIDIAGONAL will fix
this problem but as mentioned above this can be quite
expensive depending on the problem.

This change extends the visibility based preconditioner
to allow for multiple clustering algorithms. And adds
a simple thresholded single linkage clustering algorithm
which allows you to construct versions of CLUSTER_JACOBI
and CLUSTER_TRIDIAGONAL preconditioners that are cheap
to construct and are more effective than SCHUR_JACOBI.

Currently the constants controlling the threshold above
which edges are considered in the single linkage algorithm
are not exposed. This would be done in a future change.

Change-Id: I7ddc36790943f24b19c7f08b10694ae9a822f5c9
2013-10-31 13:22:57 -07:00
Sameer Agarwal 9e9a7d6ca0 Documentation update.
Add documentation for the new methods added to Problem.
Fix a bunch of ReST bugs.

Change-Id: I8a79a84040cfa8a679cc5355baccbe6d69bc9e70
2013-10-29 06:54:44 -07:00
Alex Stewart f51f56382c Documentation update.
- Adding documentation for MSVC CRT option.
- Updating documentation to reflect that LINE_SEARCH_MINIMIZER is now
  ON by default.

Change-Id: I75b1b5957c3ab46f38631736ad1c65315bc92847
2013-10-22 14:37:42 +01:00