10 Commits

Author	SHA1	Message	Date
Sameer Agarwal	5a30cae583	Preparing for 2.2.0rc1 ... 1. Add a version history 2. Update copyright years across the code base 3. Run format_all.sh 4. Update version strings from 2.1.0 to 2.2.0 in the docs and elsewhere. Change-Id: I46d8d479d54bd6002d532785e67342106e73c9ac	2023-09-21 11:23:38 -07:00
Sameer Agarwal	caf614a6c1	Modernize code using c++17 constructs ... Mostly done using find . \( -name '*.cc' -o -name '*.h' \) -a -type f -exec clang-tidy -p \ cmake-build -checks='-*,google-*,modernize-*,-modernize-use-nodiscard,-modernize-use-trailing-return-type' {} -fix \; Change-Id: Ifccbcabe7a1d9a32a09d28ac4f3f8466696c1a50	2022-04-22 06:11:18 -07:00
Sergiu Deitsch	c14f360e63	Drop trivial special members ... Do not define trivial constructors or destructors unless necessary (e.g., for implementing pimpl) following the rule of zero. Define virtual base class destructors out-of-line to avoid emitting vtables in every translation unit. Change-Id: Iea2d8978e62a8ee5a97b86cbb4e858d56e0fb274	2022-02-09 21:30:14 +01:00
Sergiu Deitsch	a35bd1bf90	Use = default for trivial special members ... Applied changes correspond to clang-tidy fixes stemming from the modernize-use-equals-default check. Change-Id: I254b0908a76d464131564b637cd0e42a6b03fb5a	2022-02-09 18:38:52 +01:00
Sergiu Deitsch	484d3414e4	Replace virtual keyword by override ... virtual can be ambiguous. Applied changes correspond to clang-tidy fixes stemming from the modernize-use-override check. Change-Id: I973afd4680a5df587419777504aeb94467196b89	2022-02-09 00:34:05 +01:00
Nikolaus Demmel	7b8f675bfd	fix formatting for (non-generated) internal source files ... - Change formatting standard to Cpp11. Main difference is not having the space between two closing >> for nested templates. We don't choose c++14, because older versions of clang-format (version 9 and earlier) don't know this value yet, and it doesn't make a difference in the formatting. - Apply clang-format to all (non generated) internal source files. - Manually fix some code sections (clang-format on/off) and c-strings - Exclude some embedded external files with very different formatting (gtest/gmock) - Add script to format all source files Change-Id: Ic6cea41575ad6e37c9e136dbce176b0d505dc44d	2020-09-21 02:52:07 +02:00
Sameer Agarwal	2ffddaccfe	Use override & final instead of just using virtual. ... This is safer than using virtual and this lead to a minor bug fixes. Change-Id: Id69cb1cc569bf6bf245f22f029c7871b6c712568	2019-07-25 16:29:14 -07:00
Keir Mierle	7492b0d8de	Update copyright headers with new year and URL ... Since Ceres is moving to using GitHub for issues, and the Google Code URL in the current copyright header will soon become invalid, update all the headers. Change-Id: I1fce70375d1bcf098591f07b4d8f01a5c1e0789c	2015-03-18 05:43:23 +00:00
Sameer Agarwal	0e811b0881	Fix a bug in Minimizer::RunCallbacks. ... Solver::Summary::message was not being updated when the solver terminated because of a user's iteration callback indicating success or failure. Thanks to Sergey Sharybin for reporting this. Change-Id: I27e6e5eed086920ddf765461b0159417ac79d7b3	2014-05-01 11:39:37 -07:00
Keir Mierle	f747183ec0	Fix user iteration callbacks. ... User callbacks got broken at some point due to the extra layer of copying from Solver::Options to Minimizer::Options. This copies the user callbacks when initializing Minimizer::Options from Solver::Options, and adds a test to this effect. This also fixes a bug where the state updating callback was not called before the user callbacks. This also adds a test to solver_impl_test to ensure the state updating callbacks work as expected. Thanks to Luis Alberto Zarrabeitia for the report. Issue: 46 Change-Id: I2b36415c89dafaa5c84ecaa727a325df122e1092	2012-06-18 00:49:58 -07:00