From a0cefc3347c32b2065053bbaff4f34d11529d931 Mon Sep 17 00:00:00 2001 From: Sameer Agarwal Date: Thu, 3 May 2012 08:38:33 -0700 Subject: [PATCH 1/3] Arnaus Gelas' patch to move to Ctest --- CMakeLists.txt | 2 +- internal/ceres/CMakeLists.txt | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 70336ae46..ed7dbc148 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -36,7 +36,7 @@ ENDIF (COMMAND cmake_policy) PROJECT(CERES C CXX) -ENABLE_TESTING() +INCLUDE(CTest) # SuiteSparse OPTION(SUITESPARSE diff --git a/internal/ceres/CMakeLists.txt b/internal/ceres/CMakeLists.txt index f02db2326..7891138e5 100644 --- a/internal/ceres/CMakeLists.txt +++ b/internal/ceres/CMakeLists.txt @@ -139,8 +139,7 @@ ENDIF (PROTOBUF_FOUND) TARGET_LINK_LIBRARIES(ceres ${CERES_LIBRARY_DEPENDENCIES}) -OPTION(BUILD_TESTS "Build the unit tests." ON) -IF (BUILD_TESTS) +IF (BUILD_TESTING) ADD_LIBRARY(gtest gmock_gtest_all.cc gmock_main.cc) ADD_LIBRARY(test_util test_util.cc) TARGET_LINK_LIBRARIES(gtest ${GFLAGS_LIB} ${GLOG_LIB}) @@ -193,4 +192,4 @@ IF (BUILD_TESTS) CERES_TEST(unsymmetric_linear_solver) CERES_TEST(visibility) CERES_TEST(visibility_based_preconditioner) -ENDIF (BUILD_TESTS) +ENDIF (BUILD_TESTING) From a9b8e815e1c026599734510399b10f4cf014c9cd Mon Sep 17 00:00:00 2001 From: Sameer Agarwal Date: Thu, 3 May 2012 08:41:52 -0700 Subject: [PATCH 2/3] Arnaus Gelas' patch to add .gitignore --- .gitignore | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000000000..400976521 --- /dev/null +++ b/.gitignore @@ -0,0 +1,14 @@ +*~ +CMakeLists.txt.user* +*.kdev* +*.bak +*.orig +build/ +*.aux +*.blg +*.toc +*.fdb_latexmk +*.bbl +*.log +*.synctex.gz +ceres.pdf \ No newline at end of file From e0a52a993394e73bc7f7db8d520728926feab83e Mon Sep 17 00:00:00 2001 From: Sameer Agarwal Date: Thu, 3 May 2012 08:43:34 -0700 Subject: [PATCH 3/3] Arnaus Gelas' patch to add better path searching for gflags and glog --- CMakeLists.txt | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ed7dbc148..8213e6afd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -168,8 +168,20 @@ OPTION(GFLAGS IF (GFLAGS) MESSAGE("-- Check for Google Flags") - FIND_LIBRARY(GFLAGS_LIB NAMES gflags) - FIND_PATH(GFLAGS_INCLUDE NAMES gflags/gflags.h) + FIND_LIBRARY(GFLAGS_LIB + NAMES + gflags + PATH + /usr/lib + /usr/local/lib + ) + FIND_PATH(GFLAGS_INCLUDE + NAMES + gflags/gflags.h + PATH + /usr/include + /usr/local/include + ) IF (NOT EXISTS ${GFLAGS_LIB} OR NOT EXISTS ${GFLAGS_INCLUDE}) MESSAGE(FATAL_ERROR "Can't find Google Flags. Please specify: " @@ -184,8 +196,20 @@ ENDIF (GFLAGS) # Google Logging MESSAGE("-- Check for Google Log") -FIND_LIBRARY(GLOG_LIB NAMES glog) -FIND_PATH(GLOG_INCLUDE NAMES glog/logging.h) +FIND_LIBRARY(GLOG_LIB + NAMES + glog + PATH + /usr/lib + /usr/local/lib +) +FIND_PATH(GLOG_INCLUDE + NAMES + glog/logging.h + PATH + /usr/include + /usr/local/include +) IF (NOT EXISTS ${GLOG_LIB} OR NOT EXISTS ${GLOG_INCLUDE}) MESSAGE(FATAL_ERROR "Can't find Google Log. Please specify: "