From d6a93100981ab0dbe329c94db06b89ca3cf0860c Mon Sep 17 00:00:00 2001 From: Sameer Agarwal Date: Tue, 1 Nov 2022 10:46:50 -0700 Subject: [PATCH] Clang Tidy Fixes Change-Id: I65558225cc537e86428caa5081bde165968bfab3 --- internal/ceres/block_sparse_matrix.cc | 2 +- internal/ceres/block_sparse_matrix_test.cc | 3 +++ internal/ceres/evaluation_benchmark.cc | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/ceres/block_sparse_matrix.cc b/internal/ceres/block_sparse_matrix.cc index 0e05693e5..053b3c081 100644 --- a/internal/ceres/block_sparse_matrix.cc +++ b/internal/ceres/block_sparse_matrix.cc @@ -48,7 +48,7 @@ namespace ceres::internal { namespace { void ComputeCumulativeNumberOfNonZeros(std::vector& rows) { - if (!rows.size()) { + if (rows.empty()) { return; } rows[0].cumulative_nnz = rows[0].nnz; diff --git a/internal/ceres/block_sparse_matrix_test.cc b/internal/ceres/block_sparse_matrix_test.cc index 62bb0f466..cfed04199 100644 --- a/internal/ceres/block_sparse_matrix_test.cc +++ b/internal/ceres/block_sparse_matrix_test.cc @@ -30,8 +30,11 @@ #include "ceres/block_sparse_matrix.h" +#include #include +#include #include +#include #include "ceres/casts.h" #include "ceres/crs_matrix.h" diff --git a/internal/ceres/evaluation_benchmark.cc b/internal/ceres/evaluation_benchmark.cc index 1fdc8d2c4..b18f563d2 100644 --- a/internal/ceres/evaluation_benchmark.cc +++ b/internal/ceres/evaluation_benchmark.cc @@ -29,6 +29,7 @@ // Authors: dmitriy.korchemkin@gmail.com (Dmitriy Korchemkin) #include +#include #include #include