From d4e3ba3173ce6323c481fca9e6a0cc514a65936d Mon Sep 17 00:00:00 2001 From: Sergiu Deitsch Date: Sun, 28 Sep 2025 08:35:41 +0200 Subject: [PATCH] Ensure consistent visibility attributes Change-Id: Ib80d655a3601a716956bbd2b977d295a809307c1 --- internal/ceres/conjugate_gradients_solver.h | 5 +++-- internal/ceres/eigensparse.cc | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/internal/ceres/conjugate_gradients_solver.h b/internal/ceres/conjugate_gradients_solver.h index ee0919b8d..ba70a139b 100644 --- a/internal/ceres/conjugate_gradients_solver.h +++ b/internal/ceres/conjugate_gradients_solver.h @@ -60,7 +60,8 @@ class ConjugateGradientsLinearOperator { // Adapter class that makes LinearOperator appear like an instance of // ConjugateGradientsLinearOperator. -class LinearOperatorAdapter : public ConjugateGradientsLinearOperator { +class CERES_NO_EXPORT LinearOperatorAdapter + : public ConjugateGradientsLinearOperator { public: LinearOperatorAdapter(LinearOperator& linear_operator) : linear_operator_(linear_operator) {} @@ -75,7 +76,7 @@ class LinearOperatorAdapter : public ConjugateGradientsLinearOperator { // Options to control the ConjugateGradientsSolver. For detailed documentation // for each of these options see linear_solver.h -struct ConjugateGradientsSolverOptions { +struct CERES_NO_EXPORT ConjugateGradientsSolverOptions { int min_num_iterations = 1; int max_num_iterations = 1; int residual_reset_period = 10; diff --git a/internal/ceres/eigensparse.cc b/internal/ceres/eigensparse.cc index 9e2b43eb8..1bc16b6c7 100644 --- a/internal/ceres/eigensparse.cc +++ b/internal/ceres/eigensparse.cc @@ -52,6 +52,8 @@ namespace ceres::internal { +namespace { + template class EigenSparseCholeskyTemplate final : public SparseCholesky { public: @@ -146,6 +148,8 @@ class EigenSparseCholeskyTemplate final : public SparseCholesky { Solver solver_; }; +} // namespace + std::unique_ptr EigenSparseCholesky::Create( const OrderingType ordering_type) { using WithAMDOrdering = Eigen::SimplicialLDLT,