saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-30 09:00:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Modernize more

Browse Source 
Apply clang-tidy Google and modernize fixes without trailing return type
using:

$ clang-tidy -p <build-dir> \
  -checks='-*,google-*,modernize-*,-modernize-use-trailing-return-type' {} -fix

Change-Id: I7450cc58ea9abf928f73a467e87876083217fa26
This commit is contained in:
Sergiu Deitsch
2022-02-20 02:22:17 +01:00
committed by Sameer Agarwal
parent 46b3495a4f
commit c8658c8992
172 changed files with 918 additions and 983 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/ceres/numeric_diff_test_utils.cc
+11 -11
View File
@@ -1,5 +1,5 @@
// Ceres Solver - A fast non-linear least squares minimizer
// Copyright 2015 Google Inc. All rights reserved.
// Copyright 2022 Google Inc. All rights reserved.
// http://ceres-solver.org/
//
// Redistribution and use in source and binary forms, with or without
@@ -149,9 +149,9 @@ void TranscendentalFunctor::ExpectCostFunctionEvaluationIsNearlyCorrect(
};
// clang-format on
for (int k = 0; k < kTests.size(); ++k) {
double* x1 = &(kTests[k].x1[0]);
double* x2 = &(kTests[k].x2[0]);
for (auto& test : kTests) {
double* x1 = &(test.x1[0]);
double* x2 = &(test.x2[0]);
double* parameters[] = {x1, x2};
double dydx1[10];
@@ -207,8 +207,8 @@ void ExponentialFunctor::ExpectCostFunctionEvaluationIsNearlyCorrect(
// Minimal tolerance w.r.t. the cost function and the tests.
const double kTolerance = 2e-14;
for (int k = 0; k < kTests.size(); ++k) {
double* parameters[] = {&kTests[k]};
for (double& test : kTests) {
double* parameters[] = {&test};
double dydx;
double* jacobians[1] = {&dydx};
double residual;
@@ -216,7 +216,7 @@ void ExponentialFunctor::ExpectCostFunctionEvaluationIsNearlyCorrect(
ASSERT_TRUE(
cost_function.Evaluate(&parameters[0], &residual, &jacobians[0]));
double expected_result = exp(kTests[k]);
double expected_result = exp(test);
// Expect residual to be close to exp(x).
ExpectClose(residual, expected_result, kTolerance);
@@ -248,8 +248,8 @@ void RandomizedFunctor::ExpectCostFunctionEvaluationIsNearlyCorrect(
// Initialize random number generator with given seed.
srand(random_seed_);
for (int k = 0; k < kTests.size(); ++k) {
double* parameters[] = {&kTests[k]};
for (double& test : kTests) {
double* parameters[] = {&test};
double dydx;
double* jacobians[1] = {&dydx};
double residual;
@@ -258,10 +258,10 @@ void RandomizedFunctor::ExpectCostFunctionEvaluationIsNearlyCorrect(
cost_function.Evaluate(&parameters[0], &residual, &jacobians[0]));
// Expect residual to be close to x^2 w.r.t. noise factor.
ExpectClose(residual, kTests[k] * kTests[k], noise_factor_);
ExpectClose(residual, test * test, noise_factor_);
// Check evaluated differences. (dy/dx = ~2x)
ExpectClose(dydx, 2 * kTests[k], kTolerance);
ExpectClose(dydx, 2 * test, kTolerance);
}
}