saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-29 08:34:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Move EvaluationCallback from Solver::Options to Problem::Options.

Browse Source 
Adding it to Solver::Options was a mistake, as it prevents it from
being used in covariance estimation. Also updated associated docs.

https://github.com/ceres-solver/ceres-solver/issues/380
https://github.com/ceres-solver/ceres-solver/issues/401
https://github.com/ceres-solver/ceres-solver/issues/484

Change-Id: I63809a47a58e84c04a58bf8e59ace92f45fc2873
This commit is contained in:
Sameer Agarwal
2019-06-04 21:57:01 -07:00
parent 059bcb7f86
commit bf709ecac2
15 changed files with 393 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/ceres/solver.cc
-8
View File
@@ -128,14 +128,6 @@ bool TrustRegionOptionsAreValid(const Solver::Options& options, string* error) {
OPTION_GE(inner_iteration_tolerance, 0.0);
}
if (options.use_inner_iterations &&
options.evaluation_callback != NULL) {
*error = "Inner iterations (use_inner_iterations = true) can't be "
"combined with an evaluation callback "
"(options.evaluation_callback != NULL).";
return false;
}
if (options.use_nonmonotonic_steps) {
OPTION_GT(max_consecutive_nonmonotonic_steps, 0);
}