saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-29 16:40:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use compiler attributes instead of [[deprecated]]

Browse Source 
This change is needed because compiler attributes and c++
annotations like [[deprecated]] do not mix well and we need that
for our public API.

https://github.com/ceres-solver/ceres-solver/issues/749

Change-Id: I79eda795f2912f9af9ab36ee24b8428b47104743
This commit is contained in:
Sameer Agarwal
2022-02-10 15:15:11 -08:00
parent 44039af2cb
commit 9c5f29d46d
8 changed files with 115 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/ceres/gradient_problem.h
+10 -9
View File
@@ -105,11 +105,11 @@ class CERES_EXPORT GradientProblem {
// NOTE: This constructor is deprecated and will be removed in the next public
// release of Ceres Solver. Please move to using the Manifold based
// constructor.
[[deprecated(
CERES_DEPRECATED_WITH_MSG(
"LocalParameterizations are deprecated. Please use the constructor that "
"uses Manifold instead.")]] GradientProblem(FirstOrderFunction* function,
LocalParameterization*
parameterization);
"uses Manifold instead.")
GradientProblem(FirstOrderFunction* function,
LocalParameterization* parameterization);
// Takes ownership of the function and the manifold.
GradientProblem(FirstOrderFunction* function, Manifold* manifold);
@@ -154,8 +154,8 @@ class CERES_EXPORT GradientProblem {
//
// NOTE: This method is deprecated and will be removed in the next public
// release of Ceres Solver.
[[deprecated("Use Manifolds instead.")]] const LocalParameterization*
parameterization() const {
CERES_DEPRECATED_WITH_MSG("Use Manifolds instead.")
const LocalParameterization* parameterization() const {
return parameterization_.get();
}
@@ -164,14 +164,15 @@ class CERES_EXPORT GradientProblem {
//
// NOTE: This method is deprecated and will be removed in the next public
// release of Ceres Solver.
[[deprecated("Use Manifolds instead.")]] LocalParameterization*
mutable_parameterization() {
CERES_DEPRECATED_WITH_MSG("Use Manifolds instead.")
LocalParameterization* mutable_parameterization() {
return parameterization_.get();
}
private:
std::unique_ptr<FirstOrderFunction> function_;
[[deprecated]] std::unique_ptr<LocalParameterization> parameterization_;
CERES_DEPRECATED_WITH_MSG("")
std::unique_ptr<LocalParameterization> parameterization_;
std::unique_ptr<Manifold> manifold_;
std::unique_ptr<double[]> scratch_;
};