From 8a545eb46b6aae9c91861bb1104c7cdc530487ee Mon Sep 17 00:00:00 2001 From: Sergiu Deitsch Date: Sun, 8 Jun 2025 12:57:49 +0200 Subject: [PATCH] Update dependencies to support GCC 15 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, compiling using GCC failed with In file included from /usr/include/c++/15.1.1/cassert:46, from /third_party/abseil-cpp/absl/container/internal/container_memory.h:18, from /third_party/abseil-cpp/absl/container/flat_hash_map.h:40, from /third_party/abseil-cpp/absl/flags/reflection.h:29, from /third_party/abseil-cpp/absl/flags/reflection.cc:16: /third_party/abseil-cpp/absl/container/internal/container_memory.h: In function ‘void* absl::lts_20240116::container_internal::Allocate(Alloc*, size_t)’: /third_party/abseil-cpp/absl/container/internal/container_memory.h:66:27: error: ‘uintptr_t’ does not name a type [-Wtemplate-body] 66 | assert(reinterpret_cast(p) % Alignment == 0 && | ^~~~~~~~~ /third_party/abseil-cpp/absl/container/internal/container_memory.h:31:1: note: ‘uintptr_t’ is defined in header ‘’; this is probably fixable by adding ‘#include ’ 30 | #include "absl/utility/utility.h" +++ |+#include 31 | Additionally, the previous version of Abseil errouneously depends on googletest when Ceres is consumed which results in issues with downstream projects. We therefore update both dependencies to avoid these issues. Thanks to @adam-ce for figuring out the working versions of Abseil and googletest. Fixes #1140 Change-Id: Ie991da04491d42979d51b891a4565cabbb1c604b --- .gitmodules | 4 ++-- third_party/abseil-cpp | 2 +- third_party/googletest | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitmodules b/.gitmodules index e15103c1c..61f706498 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,8 +1,8 @@ [submodule "third_party/googletest"] path = third_party/googletest url = https://github.com/google/googletest.git - branch = v1.14.x + branch = v1.16.x [submodule "third_party/abseil-cpp"] path = third_party/abseil-cpp url = https://github.com/abseil/abseil-cpp - branch = lts_2024_01_16 + branch = lts_2025_01_27 diff --git a/third_party/abseil-cpp b/third_party/abseil-cpp index d7aaad83b..9ac7062b1 160000 --- a/third_party/abseil-cpp +++ b/third_party/abseil-cpp @@ -1 +1 @@ -Subproject commit d7aaad83b488fd62bd51c81ecf16cd938532cc0a +Subproject commit 9ac7062b1860d895fb5a8cbf58c3e9ef8f674b5f diff --git a/third_party/googletest b/third_party/googletest index 1d17ea141..6910c9d91 160000 --- a/third_party/googletest +++ b/third_party/googletest @@ -1 +1 @@ -Subproject commit 1d17ea141d2c11b8917d2c7d029f1c4e2b9769b2 +Subproject commit 6910c9d9165801d8827d628cb72eb7ea9dd538c5