saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-29 08:34:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Reduce the minimum required version of Abseil

Browse Source 
1. The required version of Abseil is now 20240116.0 instead of 20240116.2.
   This was an oversight. Thanks to @NeroBurner for pointing this out.
   Both CMake and Bazel builds are updated.

2. Unbreak the Bazel build which had become stale.

Change-Id: I274bbad2f94f7710387f9693de9c66b035758970
This commit is contained in:
Sameer Agarwal
2024-09-09 08:45:27 -07:00
parent ea4400cd57
commit 6aa7df9650
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CMakeLists.txt
+2 -2
View File
@@ -157,8 +157,8 @@ else()
# For some reason unknown to me having the version number in the # For some reason unknown to me having the version number in the
# find_package call fails. So we check for he minimum version # find_package call fails. So we check for he minimum version
# manually. # manually.
if (absl_VERSION VERSION_LESS 20240116.2) if (absl_VERSION VERSION_LESS 20240116)
message(FATAL_ERROR "The version of abseil installed on the system is " ${absl_VERSION} " need at least 20240116.2") message(FATAL_ERROR "The version of abseil installed on the system is " ${absl_VERSION} " need at least 20240116")
endif() endif()
endif() endif()
MODULE.bazel
+2 -1
View File
@@ -1,6 +1,7 @@
# MODULE.bazel # MODULE.bazel
bazel_dep(name = "abseil-cpp", version = "20240116.2") bazel_dep(name = "abseil-cpp", version = "20240116.0")
bazel_dep(name = "googletest", version = "1.14.0") bazel_dep(name = "googletest", version = "1.14.0")
bazel_dep(name = "eigen", version = "3.4.0") bazel_dep(name = "eigen", version = "3.4.0")
bazel_dep(name = "google_benchmark", version = "1.8.4") bazel_dep(name = "google_benchmark", version = "1.8.4")
bazel/ceres.bzl
+1 -3
View File
@@ -68,9 +68,9 @@ CERES_SRCS = ["internal/ceres/" + filename for filename in [
"eigensparse.cc", "eigensparse.cc",
"evaluation_callback.cc", "evaluation_callback.cc",
"evaluator.cc", "evaluator.cc",
"event_logger.cc",
"file.cc", "file.cc",
"first_order_function.cc", "first_order_function.cc",
"float_suitesparse.cc",
"function_sample.cc", "function_sample.cc",
"gradient_checker.cc", "gradient_checker.cc",
"gradient_checking_cost_function.cc", "gradient_checking_cost_function.cc",
@@ -121,7 +121,6 @@ CERES_SRCS = ["internal/ceres/" + filename for filename in [
"sparse_cholesky.cc", "sparse_cholesky.cc",
"sparse_matrix.cc", "sparse_matrix.cc",
"sparse_normal_cholesky_solver.cc", "sparse_normal_cholesky_solver.cc",
"stringprintf.cc",
"subset_preconditioner.cc", "subset_preconditioner.cc",
"suitesparse.cc", "suitesparse.cc",
"thread_pool.cc", "thread_pool.cc",
@@ -134,7 +133,6 @@ CERES_SRCS = ["internal/ceres/" + filename for filename in [
"types.cc", "types.cc",
"visibility_based_preconditioner.cc", "visibility_based_preconditioner.cc",
"visibility.cc", "visibility.cc",
"wall_time.cc",
]] ]]
# TODO(rodrigoq): add support to configure Ceres into various permutations, # TODO(rodrigoq): add support to configure Ceres into various permutations,