saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-29 08:34:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove the use of CHECK_NOTNULL.

Browse Source 
Change-Id: I6aa7dd5b44bd42807118b4b0b565d6fa8b227371
This commit is contained in:
Sameer Agarwal
2022-01-19 07:00:32 -08:00
parent 125a0e9be5
commit 611b46b54b
2 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/ceres/gradient_problem.cc
+18 -7
View File
@@ -37,24 +37,35 @@
namespace ceres {
GradientProblem::GradientProblem(FirstOrderFunction* function)
: function_(CHECK_NOTNULL(function)),
: function_(function),
manifold_(new EuclideanManifold(function_->NumParameters())),
scratch_(new double[function_->NumParameters()]) {}
scratch_(new double[function_->NumParameters()]) {
CHECK(function != nullptr);
}
GradientProblem::GradientProblem(FirstOrderFunction* function,
LocalParameterization* parameterization)
: function_(CHECK_NOTNULL(function)),
parameterization_(CHECK_NOTNULL(parameterization)),
manifold_(new internal::ManifoldAdapter(parameterization_.get())),
: function_(function),
parameterization_(parameterization),
scratch_(new double[function_->NumParameters()]) {
CHECK(function != nullptr);
if (parameterization != nullptr) {
manifold_.reset(new internal::ManifoldAdapter(parameterization_.get()));
} else {
manifold_.reset(new EuclideanManifold(function_->NumParameters()));
}
CHECK_EQ(function_->NumParameters(), manifold_->AmbientSize());
}
GradientProblem::GradientProblem(FirstOrderFunction* function,
Manifold* manifold)
: function_(CHECK_NOTNULL(function)),
manifold_(CHECK_NOTNULL(manifold)),
: function_(function),
manifold_(manifold),
scratch_(new double[function_->NumParameters()]) {
CHECK(function != nullptr);
if (manifold == nullptr) {
manifold_.reset(new EuclideanManifold(function_->NumParameters()));
}
CHECK_EQ(function_->NumParameters(), manifold_->AmbientSize());
}
internal/ceres/manifold_adapter.h
+4 -1
View File
@@ -11,7 +11,10 @@ namespace internal {
class ManifoldAdapter : public Manifold {
public:
ManifoldAdapter(const LocalParameterization* local_parameterization)
: local_parameterization_(CHECK_NOTNULL(local_parameterization)) {}
: local_parameterization_(local_parameterization) {
CHECK(local_parameterization != nullptr);
}
virtual ~ManifoldAdapter() {}
bool Plus(const double* x,