From 603277d34392eeb14cd194f7e22b0d6db247ee1e Mon Sep 17 00:00:00 2001 From: Sameer Agarwal Date: Tue, 10 Jun 2014 10:00:45 -0700 Subject: [PATCH] Add check for dynamic sparsity in Solver::Options::IsValid. Dynamic sparsity should only be used with SPARSE_NORMAL_CHOLESKY. Change-Id: I8dd33c05ec0337b3c13b547ecffe3aefc3e5ab12 --- internal/ceres/solver.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/internal/ceres/solver.cc b/internal/ceres/solver.cc index 8f198860f..e99ddc9bb 100644 --- a/internal/ceres/solver.cc +++ b/internal/ceres/solver.cc @@ -216,6 +216,12 @@ bool TrustRegionOptionsAreValid(const Solver::Options& options, string* error) { return false; } + if (options.dynamic_sparsity && + options.linear_solver_type != SPARSE_NORMAL_CHOLESKY) { + *error = "Dynamic sparsity is only supported with SPARSE_NORMAL_CHOLESKY."; + return false; + } + return true; }