saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-29 08:34:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not dereference an iterator when it point to the end.

Browse Source 
Thanks to Markus Moll for catching my broken fix from a previous change.

Change-Id: I37d0185cfc6f86d0c31f580ca988577abc168ab5
This commit is contained in:
Sameer Agarwal
2012-06-14 13:47:43 -07:00
parent 59534c193b
commit 32808202dc
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/ceres/suitesparse.cc
+10 -3
View File
@@ -224,9 +224,16 @@ void SuiteSparse::ScalarMatrixToBlockMatrix(const cholmod_sparse* A,
vector<int>::const_iterator it = lower_bound(row_block_starts.begin(),
row_block_starts.end(),
scalar_rows[idx]);
// Only consider the first row of each row block.
if (*it != scalar_rows[idx]) {
// Since we are using lower_bound, it will return the row id
// where the row block starts. For everything but the first row
// of the block, where these values will be the same, we can
// skip, as we only need the first row to detect the presence of
// the block.
//
// For rows all but the first row in the last row block,
// lower_bound will return row_block_starts.end(), but those can
// be skipped like the rows in other row blocks too.
if (it == row_block_starts.end() || *it != scalar_rows[idx]) {
continue;
}