From 2c1c0932e9d3f91691e5c5fce46b4440e181a8bc Mon Sep 17 00:00:00 2001 From: Sameer Agarwal Date: Mon, 23 Mar 2020 11:15:32 -0700 Subject: [PATCH] Update documentation in autodiff.h Change-Id: Icc2753b4f5be95022ffd92e479cdd3d9d7959d4c --- include/ceres/internal/autodiff.h | 6 +++--- internal/ceres/local_parameterization.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ceres/internal/autodiff.h b/include/ceres/internal/autodiff.h index cefcfb4c0..4b97b5ba8 100644 --- a/include/ceres/internal/autodiff.h +++ b/include/ceres/internal/autodiff.h @@ -206,9 +206,9 @@ struct Make1stOrderPerturbation { // If one having three parameter blocks with dimensions (3, 2, 4), the call // Make1stOrderPerturbations::Apply(params, x); // will result in the following calls to Make1stOrderPerturbation: -// Make1stOrderPerturbation<0, 3>(params[0], x + 0); -// Make1stOrderPerturbation<3, 2>(params[1], x + 3); -// Make1stOrderPerturbation<5, 4>(params[2], x + 5); +// Make1stOrderPerturbation<0, 0, 3>::Apply(params[0], x + 0); +// Make1stOrderPerturbation<0, 3, 2>::Apply(params[1], x + 3); +// Make1stOrderPerturbation<0, 5, 4>::Apply(params[2], x + 5); template struct Make1stOrderPerturbations; diff --git a/internal/ceres/local_parameterization.cc b/internal/ceres/local_parameterization.cc index 9e1f2a4b5..b6316f18a 100644 --- a/internal/ceres/local_parameterization.cc +++ b/internal/ceres/local_parameterization.cc @@ -313,7 +313,7 @@ bool ProductParameterization::ComputeJacobian(const double* x, int x_cursor = 0; int delta_cursor = 0; - for (const auto& param : local_params_) { + for (const auto& param : local_params_) { const int local_size = param->LocalSize(); const int global_size = param->GlobalSize();