From 044786669dcfbd1cd16f8ba20512a1b8abfc6bcd Mon Sep 17 00:00:00 2001 From: Arnaud Gelas Date: Thu, 20 Jun 2013 17:12:36 +0200 Subject: [PATCH] Enforce the read call returns correct value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix compilation error on Ubuntu 12.0 In file included from /usr/include/fcntl.h:252:0, from /home/ajg23/src/ceres-solver/examples/libmv_bundle_adjuster.cc:91: /home/ajg23/src/ceres-solver/examples/libmv_bundle_adjuster.cc: In member function ‘T {anonymous}::EndianAwareFileReader::Read() const [with T = unsigned char]’: /home/ajg23/src/ceres-solver/examples/libmv_bundle_adjuster.cc:300:5: error: ignoring return value of ‘ssize_t read(int, void*, size_t)’, declared with attribute warn_unused_result [-Werror=unused-result] Change-Id: Ib23ca19778761bbfe0d77bcf32a2181ce6db1a12 --- examples/libmv_bundle_adjuster.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/libmv_bundle_adjuster.cc b/examples/libmv_bundle_adjuster.cc index 118e53491..4b012023b 100644 --- a/examples/libmv_bundle_adjuster.cc +++ b/examples/libmv_bundle_adjuster.cc @@ -297,7 +297,7 @@ class EndianAwareFileReader { template T Read(void) const { T value; - read(file_descriptor_, &value, sizeof(value)); + CHECK_GT(read(file_descriptor_, &value, sizeof(value)), 0); // Switch endian type if file contains data in different type // that current machine. if (file_endian_type_ != host_endian_type_) {