saberbud/ceres-solver
1
0
Fork 0
mirror of https://github.com/ceres-solver/ceres-solver.git synced 2026-08-30 09:00:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

ceres/stringprintf -> absl::strings

Browse Source 
Replace ceres::String* with their more modern and performant
absl strings library equivalent and delete our string
manipulation library.

Change-Id: Iecbdba9864e0abf329778f81fdc0708f78f7594f
This commit is contained in:
Sameer Agarwal
2024-07-24 10:50:29 -07:00
parent 0ecdb82616
commit 03caeed1c6
40 changed files with 480 additions and 681 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/ceres/gradient_checking_cost_function.cc
+14 -8
View File
@@ -42,6 +42,8 @@
#include "absl/log/check.h"
#include "absl/log/log.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/str_format.h"
#include "ceres/dynamic_numeric_diff_cost_function.h"
#include "ceres/gradient_checker.h"
#include "ceres/internal/eigen.h"
@@ -50,7 +52,6 @@
#include "ceres/problem_impl.h"
#include "ceres/program.h"
#include "ceres/residual_block.h"
#include "ceres/stringprintf.h"
#include "ceres/types.h"
namespace ceres::internal {
@@ -111,9 +112,11 @@ class GradientCheckingCostFunction final : public CostFunction {
}
if (!okay) {
std::string error_log =
"Gradient Error detected!\nExtra info for this residual: " +
extra_info_ + "\n" + results.error_log;
std::string error_log = absl::StrCat(
"Gradient Error detected!\nExtra info for this residual: ",
extra_info_,
"\n",
results.error_log);
callback_->SetGradientErrorDetected(error_log);
}
return true;
@@ -145,7 +148,7 @@ void GradientCheckingIterationCallback::SetGradientErrorDetected(
std::string& error_log) {
std::lock_guard<std::mutex> l(mutex_);
gradient_error_detected_ = true;
error_log_ += "\n" + error_log;
absl::StrAppend(&error_log_, "\n", error_log);
}
std::unique_ptr<CostFunction> CreateGradientCheckingCostFunction(
@@ -231,7 +234,7 @@ std::unique_ptr<ProblemImpl> CreateGradientCheckingProblemImpl(
// ResidualBlock. This is used by the GradientCheckingCostFunction
// when logging debugging information.
std::string extra_info =
StringPrintf("Residual block id %d; depends on parameters [", i);
absl::StrFormat("Residual block id %d; depends on parameters [", i);
std::vector<double*> parameter_blocks;
std::vector<const Manifold*> manifolds;
parameter_blocks.reserve(residual_block->NumParameterBlocks());
@@ -239,8 +242,11 @@ std::unique_ptr<ProblemImpl> CreateGradientCheckingProblemImpl(
for (int j = 0; j < residual_block->NumParameterBlocks(); ++j) {
ParameterBlock* parameter_block = residual_block->parameter_blocks()[j];
parameter_blocks.push_back(parameter_block->mutable_user_state());
StringAppendF(&extra_info, "%p", parameter_block->mutable_user_state());
extra_info += (j < residual_block->NumParameterBlocks() - 1) ? ", " : "]";
absl::StrAppendFormat(
&extra_info, "%p", parameter_block->mutable_user_state());
absl::StrAppend(
&extra_info,
(j < residual_block->NumParameterBlocks() - 1) ? ", " : "]");
manifolds.push_back(
problem_impl->GetManifold(parameter_block->mutable_user_state()));
}